Added timezone for cron jobs

[shabab477]

What does it do?

I have added cron timezone configuration on the cron initialisation hook. Strapi uses node-scheduler, the way you add timezone with this library is mentioned here. I implemented the timezone feature in a similar manner

Why is it needed?

As mentioned in 3099

Related issue(s)/PR(s)

None

[codecov]

Codecov Report

Merging #8373 (c6376f7) into master (f6558c7) will increase coverage by 0.05%.
The diff coverage is 76.38%.

@@            Coverage Diff             @@
##           master    #8373      +/-   ##
==========================================
+ Coverage   33.19%   33.25%   +0.05%     
==========================================
  Files        1220     1221       +1     
  Lines       13618    13636      +18     
  Branches     1357     1359       +2     
==========================================
+ Hits         4521     4535      +14     
- Misses       8212     8217       +5     
+ Partials      885      884       -1     

Flag	Coverage Δ
front	24.70% <0.00%> (-0.02%)	⬇️
unit	54.63% <84.61%> (+0.17%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
packages/strapi-admin/services/permission.js	71.64% <ø> (-5.93%)	⬇️
...nager/admin/src/components/PreviewWysiwyg/index.js	0.00% <0.00%> (ø)
...rc/components/PreviewWysiwyg/utils/satinizeHtml.js	0.00% <0.00%> (ø)
.../src/containers/InputModalStepperProvider/index.js	0.00% <0.00%> (ø)
...-upload/admin/src/containers/ModalStepper/index.js	0.00% <0.00%> (ø)
...rapi-plugin-upload/admin/src/translations/index.js	0.00% <0.00%> (ø)
packages/strapi-utils/lib/models.js	24.69% <25.00%> (-0.31%)	⬇️
packages/strapi-admin/services/role.js	96.99% <98.00%> (+2.67%)	⬆️
packages/strapi-admin/controllers/role.js	47.16% <100.00%> (ø)
packages/strapi-admin/services/metrics.js	100.00% <100.00%> (ø)
... and 2 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fad9fda...2d25b1d. Read the comment docs.

[derrickmehaffy]

LGTM but still need eng team review

[MattieBelt]

Nice, updating the docs would also be nice :)

[shabab477]

@MattieBelt do you recommend doing this in this PR or in a separate PR? The contributing guide says documentation fixes should point to the documentation branch. Or I am taking the guide way too literally.

[MattieBelt]

Better to keep with the feature, so adding it in this PR would better.
Also the docs branch will be merged with master when Strapi has a new release. (right? @derrickmehaffy )

[derrickmehaffy]

Better to keep with the feature, so adding it in this PR would better.
Also the docs branch will be merged with master when Strapi has a new release. (right? @derrickmehaffy )

Yes, keep it with this pr, we will handle the merge of documentation. The contribution guide in that case is only for doc fixes

[alexandrebodin]

I think we should support object cron to be able to configure each cron as it work in the lib instead of adding global options.

[lauriejim]

This pull request has been mentioned on Strapi Community. There might be relevant details there:

https://forum.strapi.io/t/strapi-cron-jobs-just-for-production-environment/715/2

[shabab477]

I think we should support object cron to be able to configure each cron as it work in the lib instead of adding global options.

@alexandrebodin changed code allows both the following snippets

'*/1 * * * *': () => {
    console.log('1 minute later');
},

The change you're asking for probably needs a change like:

'*/1 * * * *': {
  task: () => {
     console.log('1 minute later');
  },
  tz: 'Asia/Dhaka'
}

I am not sure whether I have over engineered this though.

@MattieBelt Added documentation

[shabab477]

Can I get a hacktoberfest-accepted label though? I've contributed to other repos, seems like they're not available for the PR-s.

[derrickmehaffy]

Can I get a hacktoberfest-accepted label though? I've contributed to other repos, seems like they're not available for the PR-s.

No need unless DigitalOcean has changed something that we are unaware of. So long as code is merged into our master branch and it doesn't have our spam label it should count. If something has changed can you point us towards the documentation for it?

[shabab477]

Yes if it gets merged before 30th then it counts otherwise it doesn't. I don't wanna hurry this PR though, better if we take time and go with the best possible solution.

[alexandrebodin]

We could make it a be more flexible by having;

{
  '* * * * *': {
   task() {},
   options: {
    tz: '',
    // other possible options
   } 
  }
}

[alexandrebodin]

almost there ;)

[alexandrebodin]

LGTM, Refactored just a bit to make it simpler ;) Thansk for you contribution !