Skip to content

Conversation

@soupette
Copy link
Contributor

@soupette soupette commented Oct 23, 2020

What does it do?

This PR improves the front-end code of the content manager.

Why is it needed?

In order to split the logic between the single types and the collection types, fix some bugs and allow a better extension for new features and also to display the relational fields

Related issue(s)/PR(s)

soupette and others added 14 commits October 16, 2020 12:47
Signed-off-by: soupette <cyril.lpz@gmail.com>
Signed-off-by: soupette <cyril.lpz@gmail.com>
Signed-off-by: soupette <cyril.lpz@gmail.com>
Signed-off-by: soupette <cyril.lpz@gmail.com>
Signed-off-by: soupette <cyril.lpz@gmail.com>
Signed-off-by: soupette <cyril.lpz@gmail.com>
Signed-off-by: soupette <cyril.lpz@gmail.com>
Signed-off-by: soupette <cyril.lpz@gmail.com>
Signed-off-by: soupette <cyril.lpz@gmail.com>
Signed-off-by: soupette <cyril.lpz@gmail.com>
Signed-off-by: soupette <cyril.lpz@gmail.com>
@codecov
Copy link

codecov bot commented Oct 23, 2020

Codecov Report

Merging #8456 (647aff6) into feature/relational-fields (61c321f) will increase coverage by 1.07%.
The diff coverage is 25.32%.

Impacted file tree graph

@@                      Coverage Diff                      @@
##           feature/relational-fields    #8456      +/-   ##
=============================================================
+ Coverage                      33.51%   34.59%   +1.07%     
=============================================================
  Files                           1231     1263      +32     
  Lines                          13850    14043     +193     
  Branches                        1398     1395       -3     
=============================================================
+ Hits                            4642     4858     +216     
+ Misses                          8298     8293       -5     
+ Partials                         910      892      -18     
Flag Coverage Δ
front 25.85% <24.71%> (+1.14%) ⬆️
unit 55.70% <63.63%> (+1.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../Permissions/ContentTypes/ContentTypesRow/index.js 0.00% <ø> (ø)
.../admin/src/components/Roles/Permissions/reducer.js 85.41% <0.00%> (ø)
...c/components/Roles/Permissions/utils/tests/data.js 100.00% <ø> (ø)
...c/containers/LeftMenu/utils/generateModelsLinks.js 100.00% <ø> (ø)
...in/admin/src/containers/Webhooks/EditView/index.js 18.57% <0.00%> (ø)
...ts/ContentTypeBuilder/ConfigureViewButton/index.js 0.00% <0.00%> (ø)
...nt-manager/admin/src/components/CustomTable/Row.js 0.00% <0.00%> (ø)
...er/admin/src/components/CustomTable/TableHeader.js 0.00% <0.00%> (ø)
...-manager/admin/src/components/CustomTable/index.js 0.00% <0.00%> (ø)
...min/src/components/CustomTable/styledComponents.js 0.00% <ø> (ø)
... and 161 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aee6ed4...5718540. Read the comment docs.

Signed-off-by: soupette <cyril.lpz@gmail.com>
@soupette soupette changed the base branch from features/relational-fields to feature/relational-fields October 23, 2020 15:22
Signed-off-by: soupette <cyril.lpz@gmail.com>
@soupette soupette force-pushed the core/cm-refacto-ediview-container branch from 8394057 to 37913d4 Compare October 23, 2020 16:33
Signed-off-by: soupette <cyril.lpz@gmail.com>
Signed-off-by: soupette <cyril.lpz@gmail.com>
Signed-off-by: soupette <cyril.lpz@gmail.com>
Signed-off-by: soupette <cyril.lpz@gmail.com>
Signed-off-by: soupette <cyril.lpz@gmail.com>
@soupette soupette force-pushed the core/cm-refacto-ediview-container branch from 0515853 to 065aecb Compare October 26, 2020 11:37
Signed-off-by: soupette <cyril.lpz@gmail.com>
@soupette soupette force-pushed the core/cm-refacto-ediview-container branch from aa1c400 to e1dfc58 Compare October 26, 2020 13:12
Signed-off-by: soupette <cyril.lpz@gmail.com>
Signed-off-by: soupette <cyril.lpz@gmail.com>
soupette and others added 25 commits November 9, 2020 11:28
Signed-off-by: soupette <cyril.lpz@gmail.com>
Signed-off-by: soupette <cyril.lpz@gmail.com>
Signed-off-by: soupette <cyril.lpz@gmail.com>
Signed-off-by: soupette <cyril.lpz@gmail.com>
Signed-off-by: Francois AUBEUT <contact@mexar.fr>
Signed-off-by: soupette <cyril.lpz@gmail.com>
Signed-off-by: soupette <cyril.lpz@gmail.com>
Signed-off-by: soupette <cyril.lpz@gmail.com>
Signed-off-by: soupette <cyril.lpz@gmail.com>
Signed-off-by: soupette <cyril.lpz@gmail.com>
Signed-off-by: soupette <cyril.lpz@gmail.com>
Signed-off-by: soupette <cyril.lpz@gmail.com>
Signed-off-by: soupette <cyril.lpz@gmail.com>
Signed-off-by: soupette <cyril.lpz@gmail.com>
…split

Migrate RBAC views to new API format
…/strapi into MeXaaR-feature/duplicate-document
Signed-off-by: soupette <cyril.lpz@gmail.com>
Signed-off-by: soupette <cyril.lpz@gmail.com>
Signed-off-by: soupette <cyril.lpz@gmail.com>
…pi/strapi into relational-fields/split-st-ct-front
Signed-off-by: soupette <cyril.lpz@gmail.com>
Signed-off-by: soupette <cyril.lpz@gmail.com>
Copy link
Contributor

@HichamELBSI HichamELBSI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soupette soupette requested a review from HichamELBSI November 20, 2020 10:42
@HichamELBSI HichamELBSI merged commit a3e4553 into feature/relational-fields Nov 20, 2020
@HichamELBSI HichamELBSI deleted the core/cm-refacto-ediview-container branch November 20, 2020 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants