Bug: Erroneous error if there is a database configuration for a custom session middleware storage provider. #8457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8457 +/- ##
==========================================
- Coverage 35.07% 26.65% -8.43%
==========================================
Files 1308 1175 -133
Lines 14465 10149 -4316
Branches 1439 563 -876
==========================================
- Hits 5074 2705 -2369
+ Misses 8481 6950 -1531
+ Partials 910 494 -416
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Signed-off-by: Taylor Zajicek <tzajicek@flexion.us>
taylor-work
force-pushed
the
fix_custom_session_providers
branch
from
f0d04c6 to
02c8068
Compare
Signed-off-by: Taylor Zajicek <tzajicek@flexion.us>
taylor-work
force-pushed
the
fix_custom_session_providers
branch
from
f363fed to
8ac31ba
Compare
taylor-work
changed the title
|
|
alexandrebodin
added
source: core:strapi
|
Hi @taylor-work your PR has some linting issues :) can you fix those ? |
|
This pull request has been mentioned on Strapi Community Forum. There might be relevant details there: |
1 task
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
This allows for custom session providers to allow configuration of their database connection. Currently if you configure the database you will receive an error. The
!was lost in this commit ed61633#diff-1998c9159f58f279c68ead712f31e89ec0056b400cb139c3b8f6afd71da9355d Looking at the commit comments that change seems unintentional.Describe the technical changes you did.
Why is it needed?
This allows custom database settings to be set for the session middleware.
Describe the issue you are solving.
If you set
will create this error
'(middleware:session) please provide a valid connection for the session store'after this fix you will not receive this error and you will use the custom database connection for the session middleware.Related issue(s)/PR(s)
Let us know if this is related to any issue/pull request