Skip to content

Conversation

@irajtaghlidi
Copy link
Contributor

@irajtaghlidi irajtaghlidi commented Oct 23, 2020

update graphql-tools package to 4.0.8 to use GraphQL v15 syntaxes.

related to #8374

@irajtaghlidi irajtaghlidi requested a review from a team October 23, 2020 19:13
Signed-off-by: iraj <irajtaghlidi@gmail.com>
@irajtaghlidi irajtaghlidi force-pushed the upgrade-graphql-tools branch from 29fad33 to 1a6abd9 Compare October 23, 2020 19:18
@codecov
Copy link

codecov bot commented Oct 23, 2020

Codecov Report

Merging #8461 into master will decrease coverage by 8.55%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8461      +/-   ##
==========================================
- Coverage   33.26%   24.71%   -8.56%     
==========================================
  Files        1221     1103     -118     
  Lines       13629     9740    -3889     
  Branches     1357      560     -797     
==========================================
- Hits         4534     2407    -2127     
+ Misses       8211     6834    -1377     
+ Partials      884      499     -385     
Flag Coverage Δ
front 24.71% <ø> (ø)
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...strapi/lib/services/entity-validator/validators.js
...ages/strapi-generate/lib/helpers/template/index.js
...ackages/strapi/lib/load/check-reserved-filename.js
...kages/strapi-admin/validation/common-validators.js
...pi-plugin-content-type-builder/utils/attributes.js
packages/strapi-utils/lib/webhook.js
packages/strapi-plugin-upload/errors.js
packages/strapi-admin/services/content-type.js
...pi-plugin-content-manager/utils/parse-multipart.js
packages/strapi-plugin-graphql/services/naming.js
... and 107 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 717a834...9616d11. Read the comment docs.

@darron1217
Copy link
Contributor

extend syntax is not supported on current version.
Please merge this PR to support it. @derrickmehaffy

@alexandrebodin alexandrebodin added this to the 3.2.6 milestone Nov 7, 2020
@alexandrebodin alexandrebodin added source: plugin:graphql Source is plugin/graphql package issue: bug Issue reporting a bug labels Nov 7, 2020
@alexandrebodin alexandrebodin merged commit fba8959 into strapi:master Nov 7, 2020
@derrickmehaffy
Copy link
Member

This pull request has been mentioned on Strapi Community. There might be relevant details there:

https://forum.strapi.io/t/extend-user-permissions-graphql-schema/995/1

@petersg83 petersg83 modified the milestones: 3.2.6, 3.3.0 Nov 9, 2020
@iicdii
Copy link
Contributor

iicdii commented Nov 10, 2020

@derrickmehaffy
I think we need to remove this package instead of maintaining it, since apollo-server-koa includes graphql-tools itself in package.json.
I've explained this in detail in my previous PR - #6888 (comment)

hdeadman pushed a commit to hdeadman/strapi that referenced this pull request Nov 12, 2020
Signed-off-by: iraj <irajtaghlidi@gmail.com>
petersg83 pushed a commit that referenced this pull request Nov 13, 2020
Signed-off-by: iraj <irajtaghlidi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

issue: bug Issue reporting a bug source: plugin:graphql Source is plugin/graphql package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants