Fix project generation with wrong node engine spec #8497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derrick Mehaffy <derrickmehaffy@gmail.com>
derrickmehaffy
added
issue: bug
|
This pull request has been mentioned on Strapi Community. There might be relevant details there: https://forum.strapi.io/t/how-do-i-connect-heroku-to-strapi/703/8 |
Codecov Report
@@ Coverage Diff @@
## master #8497 +/- ##
==========================================
- Coverage 33.26% 33.25% -0.01%
==========================================
Files 1221 1221
Lines 13629 13635 +6
Branches 1357 1359 +2
==========================================
+ Hits 4534 4535 +1
- Misses 8211 8216 +5
Partials 884 884
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
pascalvaccaro
pushed a commit
to pascalvaccaro/strapi
that referenced
this pull request
Oct 29, 2020
Signed-off-by: Derrick Mehaffy <derrickmehaffy@gmail.com>
hdeadman
pushed a commit
to hdeadman/strapi
that referenced
this pull request
Nov 12, 2020
Signed-off-by: Derrick Mehaffy <derrickmehaffy@gmail.com>
petersg83
pushed a commit
that referenced
this pull request
Nov 13, 2020
Signed-off-by: Derrick Mehaffy <derrickmehaffy@gmail.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Derrick Mehaffy derrickmehaffy@gmail.com
What does it do?
Projects were being generated with the node engine
>=10.0.0and it was causing issues deploying on heroku which watches this to figure out which version of node to installWhy is it needed?
We don't support node v15
Related issue(s)/PR(s)
https://forum.strapi.io/t/how-do-i-connect-heroku-to-strapi/703/5