-
-
Notifications
You must be signed in to change notification settings - Fork 9.2k
Add reddit auth provider #8537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reddit auth provider #8537
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8537 +/- ##
=======================================
Coverage 34.64% 34.64%
=======================================
Files 1308 1308
Lines 14431 14431
Branches 1432 1432
=======================================
Hits 5000 5000
Misses 8517 8517
Partials 914 914
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentation/example will need to be added into: https://github.com/strapi/strapi-examples/tree/master/login-react before this can be accepted.
PR open for the example: strapi/strapi-examples#172 This PR has been updated with documentation. |
I saw, thank you ^_^ |
|
Is there an ETA on when this will be merged? |
Signed-off-by: Kyle Schwarz <zeranoe@gmail.com>
|
@derrickmehaffy not sure some docs are required but if you can add some in our doc repo @Zeranoe that would be awesome 💯 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works like a charm. I'll go ahead and merge it.
|
Yup np, we will get some docs for it. |
I've already opened a PR for the docs: strapi/documentation#66, along with an example: strapi/strapi-examples#172 |
|
Docs PR merged, I'm not a maintainer for the strapi-examples @petersg83 can you take a look? |
|
We don't really maintain the strapi-examples repo anymore & it is largely outdated. The doc is more than enough :) |
|
This pull request has been mentioned on Strapi Community Forum. There might be relevant details there: |
What does it do?
Added support for a reddit provider.
Why is it needed?
There currently is no reddit provider.