Skip to content

Conversation

@Zeranoe
Copy link
Contributor

@Zeranoe Zeranoe commented Nov 1, 2020

What does it do?

Added support for a reddit provider.

Why is it needed?

There currently is no reddit provider.

@Zeranoe Zeranoe requested a review from a team November 1, 2020 07:29
@codecov
Copy link

codecov bot commented Nov 1, 2020

Codecov Report

Merging #8537 (92c1495) into master (9fd22a9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8537   +/-   ##
=======================================
  Coverage   34.64%   34.64%           
=======================================
  Files        1308     1308           
  Lines       14431    14431           
  Branches     1432     1432           
=======================================
  Hits         5000     5000           
  Misses       8517     8517           
  Partials      914      914           
Flag Coverage Δ
front 26.04% <ø> (ø)
unit 54.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82380da...92c1495. Read the comment docs.

@soupette soupette requested review from Convly, alexandrebodin and petersg83 and removed request for a team November 2, 2020 09:14
Copy link
Member

@derrickmehaffy derrickmehaffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation/example will need to be added into: https://github.com/strapi/strapi-examples/tree/master/login-react before this can be accepted.

@Zeranoe
Copy link
Contributor Author

Zeranoe commented Nov 2, 2020

Documentation/example will need to be added into: https://github.com/strapi/strapi-examples/tree/master/login-react before this can be accepted.

PR open for the example: strapi/strapi-examples#172

This PR has been updated with documentation.

@derrickmehaffy derrickmehaffy self-requested a review November 2, 2020 21:03
@derrickmehaffy
Copy link
Member

Documentation/example will need to be added into: https://github.com/strapi/strapi-examples/tree/master/login-react before this can be accepted.

PR open for the example: strapi/strapi-examples#172

This PR has been updated with documentation.

I saw, thank you ^_^

@Zeranoe
Copy link
Contributor Author

Zeranoe commented Nov 28, 2020

Is there an ETA on when this will be merged?

@soupette soupette removed the request for review from a team November 30, 2020 08:06
@strapi-cla
Copy link

strapi-cla commented Nov 30, 2020

CLA assistant check
All committers have signed the CLA.

Signed-off-by: Kyle Schwarz <zeranoe@gmail.com>
@alexandrebodin
Copy link
Member

@derrickmehaffy not sure some docs are required but if you can add some in our doc repo @Zeranoe that would be awesome 💯

@alexandrebodin alexandrebodin added this to the 3.4.5 milestone Jan 22, 2021
@alexandrebodin alexandrebodin added source: plugin:users-permissions Source is plugin/users-permissions package issue: enhancement Issue suggesting an enhancement to an existing feature labels Jan 22, 2021
Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm. I'll go ahead and merge it.

@alexandrebodin alexandrebodin merged commit 2900584 into strapi:master Jan 22, 2021
@derrickmehaffy
Copy link
Member

Yup np, we will get some docs for it.

@Zeranoe
Copy link
Contributor Author

Zeranoe commented Jan 22, 2021

@derrickmehaffy not sure some docs are required but if you can add some in our doc repo @Zeranoe that would be awesome 💯

I've already opened a PR for the docs: strapi/documentation#66, along with an example: strapi/strapi-examples#172

@derrickmehaffy
Copy link
Member

Docs PR merged, I'm not a maintainer for the strapi-examples @petersg83 can you take a look?

@alexandrebodin
Copy link
Member

We don't really maintain the strapi-examples repo anymore & it is largely outdated. The doc is more than enough :)

@derrickmehaffy
Copy link
Member

This pull request has been mentioned on Strapi Community Forum. There might be relevant details there:

https://forum.strapi.io/t/new-release-strapi-v3-4-5/2446/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

issue: enhancement Issue suggesting an enhancement to an existing feature source: plugin:users-permissions Source is plugin/users-permissions package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants