Update gitignore in example and in generate-new #8707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petersg83
added
issue: bug
Codecov Report
@@ Coverage Diff @@
## master #8707 +/- ##
=======================================
Coverage 33.65% 33.65%
=======================================
Files 1248 1248
Lines 13765 13765
Branches 1365 1365
=======================================
Hits 4632 4632
Misses 8243 8243
Partials 890 890
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Signed-off-by: Pierre Noël <petersg83@gmail.com>
petersg83
force-pushed
the
fix/update-notifier-gitignore
branch
from
b668ace to
1cde72d
Compare
|
This pull request has been mentioned on Strapi Community. There might be relevant details there: https://forum.strapi.io/t/error-open-packages-api-strapi-updater-json-permission-denied/1255/5 |
alexandrebodin
approved these changes
Nov 25, 2020
andreamarchetti
pushed a commit
to andreamarchetti/strapi
that referenced
this pull request
Dec 29, 2020
Signed-off-by: Pierre Noël <petersg83@gmail.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.strapi-updater.jsonwas in the.gitignoreof the example app but not in the.gitignoregenerated bygenerate-new. Causing issues in some environments : https://forum.strapi.io/t/error-open-packages-api-strapi-updater-json-permission-denied/1255/2Some other variables were different between the 2 gitignores, I harmonized them.