Skip to content

Conversation

@blefevre
Copy link
Contributor

What does it do?

This PR changes the upload plugin to read the responsive image breakpoints from the config instead of being hardcoded.
The hardcoded values are still available as defaults if the config is not present.

Why is it needed?

Currently adjusting the sizing or names of the responsive images requires overriding the entire image-manipulation.js file, which is prone to errors and breaking when upgrading.

@strapi-cla
Copy link

strapi-cla commented Dec 27, 2020

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Dec 27, 2020

Codecov Report

Merging #9002 (739914d) into master (7e0d50c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9002   +/-   ##
=======================================
  Coverage   34.65%   34.65%           
=======================================
  Files        1308     1308           
  Lines       14452    14452           
  Branches     1438     1438           
=======================================
  Hits         5008     5008           
  Misses       8529     8529           
  Partials      915      915           
Flag Coverage Δ
front 26.02% <ø> (ø)
unit 54.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c05702...93b9195. Read the comment docs.

@alexandrebodin
Copy link
Member

Hi @blefevre thank you fro this PR :) I'm happy to move forward with it but you will need to update our doc so people can find the option :) Go over to our doc repo https://github.com/strapi/documentation ;)
If you need any help @derrickmehaffy is the person to talk to ;)

@alexandrebodin alexandrebodin added source: core:upload Source is core/upload package issue: enhancement Issue suggesting an enhancement to an existing feature labels Jan 25, 2021
@alexandrebodin alexandrebodin added this to the 3.4.5 milestone Jan 25, 2021
@derrickmehaffy
Copy link
Member

Hi @blefevre thank you fro this PR :) I'm happy to move forward with it but you will need to update our doc so people can find the option :) Go over to our doc repo https://github.com/strapi/documentation ;)
If you need any help @derrickmehaffy is the person to talk to ;)

Would be happy to help if you have questions about the documentation.

@blefevre
Copy link
Contributor Author

Documentation PR created here: strapi/documentation#88

@blefevre
Copy link
Contributor Author

There was some sort of issue with the tests, I've rebased onto master and it seems okay now.

Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice addition :D

@alexandrebodin alexandrebodin merged commit fd42889 into strapi:master Jan 28, 2021
@blefevre blefevre deleted the patch-1 branch January 28, 2021 18:06
@derrickmehaffy
Copy link
Member

This pull request has been mentioned on Strapi Community Forum. There might be relevant details there:

https://forum.strapi.io/t/new-release-strapi-v3-4-6/2631/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

issue: enhancement Issue suggesting an enhancement to an existing feature source: core:upload Source is core/upload package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants