-
-
Notifications
You must be signed in to change notification settings - Fork 9.2k
strapi-plugin-upload: Read responsive breakpoints from config #9002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9002 +/- ##
=======================================
Coverage 34.65% 34.65%
=======================================
Files 1308 1308
Lines 14452 14452
Branches 1438 1438
=======================================
Hits 5008 5008
Misses 8529 8529
Partials 915 915
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
Hi @blefevre thank you fro this PR :) I'm happy to move forward with it but you will need to update our doc so people can find the option :) Go over to our doc repo https://github.com/strapi/documentation ;) |
Would be happy to help if you have questions about the documentation. |
|
Documentation PR created here: strapi/documentation#88 |
|
There was some sort of issue with the tests, I've rebased onto master and it seems okay now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Nice addition :D
|
This pull request has been mentioned on Strapi Community Forum. There might be relevant details there: |
What does it do?
This PR changes the upload plugin to read the responsive image breakpoints from the config instead of being hardcoded.
The hardcoded values are still available as defaults if the config is not present.
Why is it needed?
Currently adjusting the sizing or names of the responsive images requires overriding the entire
image-manipulation.jsfile, which is prone to errors and breaking when upgrading.