Skip to content

Conversation

@mfrachet
Copy link
Contributor

@mfrachet mfrachet commented Jan 12, 2021

What does it do?

  • Provides information to M1 users on how to fix sharp troubles when setting the project up.
  • Incrementing a title number (there was two "5")

Why is it needed?

M1 users may not be able to run the project in dev mode without that.

Related issue(s)/PR(s)

Not in this repository but in the sharp's one: lovell/sharp#2460

Env

Tested on Node v12.20.1 / yarn 1.22.10

@strapi-cla
Copy link

strapi-cla commented Jan 12, 2021

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jan 12, 2021

Codecov Report

Merging #9106 (4208bf4) into master (dd0f8f0) will increase coverage by 0.03%.
The diff coverage is 70.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9106      +/-   ##
==========================================
+ Coverage   34.60%   34.64%   +0.03%     
==========================================
  Files        1308     1308              
  Lines       14416    14431      +15     
  Branches     1427     1432       +5     
==========================================
+ Hits         4989     4999      +10     
- Misses       8514     8518       +4     
- Partials      913      914       +1     
Flag Coverage Δ
front 26.04% <ø> (ø)
unit 54.85% <70.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/strapi-utils/lib/build-query.js 18.84% <0.00%> (-1.48%) ⬇️
packages/strapi-utils/lib/content-types.js 91.66% <100.00%> (ø)
packages/strapi/lib/core-api/service.js 77.77% <100.00%> (+5.05%) ⬆️
packages/strapi/lib/services/entity-service.js 44.44% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e296140...6019497. Read the comment docs.

@mfrachet mfrachet force-pushed the information-for-m1-users branch from 36a3d74 to 20d3f59 Compare January 12, 2021 15:41
@mfrachet mfrachet marked this pull request as ready for review January 12, 2021 16:13
@alexandrebodin alexandrebodin added issue: enhancement Issue suggesting an enhancement to an existing feature source: docs Documentation changes labels Jan 12, 2021
Copy link
Contributor

@soupette soupette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@derrickmehaffy derrickmehaffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

English looks good to me, can't validate content without hardware to test.

@mfrachet
Copy link
Contributor Author

@derrickmehaffy how can I help you in that scenario? Do you need a pairing session (well, now that I've run the fix, not sure how to get back 😓 ) ?

@derrickmehaffy
Copy link
Member

@derrickmehaffy how can I help you in that scenario? Do you need a pairing session (well, now that I've run the fix, not sure how to get back ) ?

It's alright :) since we have two in the team that can validate the fix, I'm not needed to validate. We might want to have a couple people in the community test as well. I'm posting a link to this PR on the resources I've seen within the community to confirm.

@derrickmehaffy
Copy link
Member

This pull request has been mentioned on Strapi Community Forum. There might be relevant details there:

https://forum.strapi.io/t/apple-silicon-m1-chip/1565/3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

issue: enhancement Issue suggesting an enhancement to an existing feature source: docs Documentation changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants