-
-
Notifications
You must be signed in to change notification settings - Fork 9.2k
Adding documentation for M1 users #9106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9106 +/- ##
==========================================
+ Coverage 34.60% 34.64% +0.03%
==========================================
Files 1308 1308
Lines 14416 14431 +15
Branches 1427 1432 +5
==========================================
+ Hits 4989 4999 +10
- Misses 8514 8518 +4
- Partials 913 914 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
36a3d74 to
20d3f59
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
English looks good to me, can't validate content without hardware to test.
|
@derrickmehaffy how can I help you in that scenario? Do you need a pairing session (well, now that I've run the fix, not sure how to get back 😓 ) ? |
It's alright :) since we have two in the team that can validate the fix, I'm not needed to validate. We might want to have a couple people in the community test as well. I'm posting a link to this PR on the resources I've seen within the community to confirm. |
|
This pull request has been mentioned on Strapi Community Forum. There might be relevant details there: |
What does it do?
Why is it needed?
M1 users may not be able to run the project in dev mode without that.
Related issue(s)/PR(s)
Not in this repository but in the sharp's one: lovell/sharp#2460
Env
Tested on Node v12.20.1 / yarn 1.22.10