-
-
Notifications
You must be signed in to change notification settings - Fork 9.2k
[Rebased] Accept info fields when uploading file through GraphQL #9172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rebased] Accept info fields when uploading file through GraphQL #9172
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9172 +/- ##
==========================================
- Coverage 34.64% 26.04% -8.60%
==========================================
Files 1308 1175 -133
Lines 14431 10127 -4304
Branches 1432 561 -871
==========================================
- Hits 5000 2638 -2362
+ Misses 8517 6991 -1526
+ Partials 914 498 -416
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thank you for contributing 🎉
|
Will do some testing debore merging :) |
|
@alexandrebodin Sure, please check it :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A small fix to avoid an issue with null value
| size: buffer.length, | ||
| }, | ||
| {}, | ||
| extraInfo, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in case we send a null value it will fail make sure to default to en empty object here :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then how about extraInfo || {}?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job thanks for the dedication :D
|
This pull request has been mentioned on Strapi Community Forum. There might be relevant details there: |
Rebased version of #8494
What does it do?
Accept info fields when uploading file through GraphQL
Why is it needed?
To send http request lesser.
Related issue(s)/PR(s)
closes #8493