Prevent returning optimized image if it's larger than original #9214
Conversation
| const optimized = await sharpInstance | ||
| .toBuffer({ resolveWithObject: true }) | ||
| .then(({ data, info }) => ({ | ||
| buffer: data, |
There was a problem hiding this comment.
can't you just do buffer.length < data.length here ? that would help us keep the simple return of promise
There was a problem hiding this comment.
Had to edit the size param below too, but indeed it looks better that way.
Codecov Report
@@ Coverage Diff @@
## master #9214 +/- ##
==========================================
- Coverage 34.64% 34.64% -0.01%
==========================================
Files 1308 1308
Lines 14431 14446 +15
Branches 1432 1435 +3
==========================================
+ Hits 5000 5005 +5
- Misses 8517 8527 +10
Partials 914 914
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
BTW. Is normal that running |
Yep the legacy code haven't been prettified to avoid conflicts so we only run them on commit (so on changed files only) :) |
alexandrebodin
added
source: core:upload
|
This pull request has been mentioned on Strapi Community Forum. There might be relevant details there: |
3 participants
What does it do?
Prevent returning optimized image if it's larger than the original. It's mostly visible on PNG images, and it's a known behavior of
sharplovell/sharp#1110, lovell/sharp#1017, lovell/sharp#600, lovell/sharp#478.Why is it needed?
When the user is uploading an already optimized image, or just the optimizer is unable to reduce the size, we should keep the image that is smaller.
Related issue(s)/PR(s)
I didn't find any of them.