Skip to content

Conversation

@soupette
Copy link
Contributor

Signed-off-by: soupette cyril.lpz@gmail.com

What does it do?

This PR fixes #9236

Signed-off-by: soupette <cyril.lpz@gmail.com>
@soupette soupette requested a review from HichamELBSI January 27, 2021 14:43
Copy link

@precious-void precious-void left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, checked, it works

@codecov
Copy link

codecov bot commented Jan 27, 2021

Codecov Report

Merging #9237 (e161bf2) into master (7e0d50c) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9237   +/-   ##
=======================================
  Coverage   34.65%   34.65%           
=======================================
  Files        1308     1308           
  Lines       14452    14450    -2     
  Branches     1438     1438           
=======================================
  Hits         5008     5008           
+ Misses       8529     8527    -2     
  Partials      915      915           
Flag Coverage Δ
front 26.03% <0.00%> (+<0.01%) ⬆️
unit 54.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ainers/EditViewDataManagerProvider/utils/schema.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd42889...0b55c84. Read the comment docs.

Copy link
Contributor

@mfrachet mfrachet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regexp are definitely not my biggest strength, but it works on my end 😊

Copy link
Contributor

@HichamELBSI HichamELBSI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derrickmehaffy
Copy link
Member

This pull request has been mentioned on Strapi Community Forum. There might be relevant details there:

https://forum.strapi.io/t/regex-error-typeerror-cannot-delete-property-regex-of-object/2519/3

@dalbitresb12
Copy link
Contributor

@derrickmehaffy Has this fix been released in v3.4.6? It isn't listed in the changelog.

@dappiu
Copy link
Contributor

dappiu commented Feb 4, 2021

@dalbitresb12 I had the same question, I checked and I can confirm that -even if not listed- it's indeed present in v3.4.6

@dalbitresb12
Copy link
Contributor

Thank you, @dappiu! I believe this one should also be added to the changelog. Friendly ping to @alexandrebodin since he was the one who posted the release?

@alexandrebodin
Copy link
Member

Hi, th label wern't addd to the PR so it didn't get a changlog lin :) will add it manually thanks for th notice !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

issue: bug Issue reporting a bug source: core:content-manager Source is core/content-manager package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Uncaught TypeError: Cannot delete property 'regex' of #<Object>

10 participants