-
-
Notifications
You must be signed in to change notification settings - Fork 9.2k
Fix regex validation #9237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix regex validation #9237
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, checked, it works
Codecov Report
@@ Coverage Diff @@
## master #9237 +/- ##
=======================================
Coverage 34.65% 34.65%
=======================================
Files 1308 1308
Lines 14452 14450 -2
Branches 1438 1438
=======================================
Hits 5008 5008
+ Misses 8529 8527 -2
Partials 915 915
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regexp are definitely not my biggest strength, but it works on my end 😊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
This pull request has been mentioned on Strapi Community Forum. There might be relevant details there: https://forum.strapi.io/t/regex-error-typeerror-cannot-delete-property-regex-of-object/2519/3 |
|
@derrickmehaffy Has this fix been released in v3.4.6? It isn't listed in the changelog. |
|
@dalbitresb12 I had the same question, I checked and I can confirm that -even if not listed- it's indeed present in v3.4.6 |
|
Thank you, @dappiu! I believe this one should also be added to the changelog. Friendly ping to @alexandrebodin since he was the one who posted the release? |
|
Hi, th label wern't addd to the PR so it didn't get a changlog lin :) will add it manually thanks for th notice ! |
Signed-off-by: soupette cyril.lpz@gmail.com
What does it do?
This PR fixes #9236