Skip to content

Conversation

@alexandrebodin
Copy link
Member

Test fix for many many perf issues

@codecov
Copy link

codecov bot commented Feb 1, 2021

Codecov Report

Merging #9286 (75ea26d) into master (d7d3fd1) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9286      +/-   ##
==========================================
- Coverage   35.09%   35.08%   -0.02%     
==========================================
  Files        1308     1308              
  Lines       14456    14461       +5     
  Branches     1438     1439       +1     
==========================================
  Hits         5074     5074              
- Misses       8473     8477       +4     
- Partials      909      910       +1     
Flag Coverage Δ
front 26.66% <0.00%> (-0.01%) ⬇️
unit 54.87% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...i-plugin-upload/admin/src/components/List/index.js 0.00% <ø> (ø)
...rapi-plugin-upload/admin/src/translations/index.js 0.00% <0.00%> (ø)
packages/strapi-utils/lib/build-query.js 17.80% <0.00%> (-1.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cf2e35...41af3ff. Read the comment docs.

@derrickmehaffy derrickmehaffy self-requested a review February 1, 2021 21:29
@abdonrd
Copy link
Contributor

abdonrd commented Feb 1, 2021

Yeah! I just tried locally and it seems to solve this problem: #8552 (comment)

Related: #9020 (comment)

@derrickmehaffy
Copy link
Member

@abdonrd if possible can you run some query speed tests against 3.4.1, 3.4.2, and this fix?

I'm hesitant to suggest it's a fix, but a start in the right direction. (Certainly this helps, but I don't have near the data sample size you do to get numbers)

@abdonrd
Copy link
Contributor

abdonrd commented Feb 2, 2021

Strapi v3.4.1:
Screenshot 2021-02-02 at 09 15 08

Strapi v3.4.2:
Screenshot 2021-02-02 at 09 13 15

Strapi v3.4.5 with this fix ⚡️:
Screenshot 2021-02-02 at 09 06 41

@alexandrebodin alexandrebodin marked this pull request as ready for review February 2, 2021 15:13
@alexandrebodin alexandrebodin changed the title test fix for many many perf issues Fix some many many perf issues in graphQL Feb 2, 2021
@alexandrebodin alexandrebodin added source: plugin:graphql Source is plugin/graphql package issue: bug Issue reporting a bug labels Feb 2, 2021
@derrickmehaffy
Copy link
Member

Wow 47 seconds down to 9ms that is quite the improvement

@abdonrd
Copy link
Contributor

abdonrd commented Feb 2, 2021

Wow 47 seconds down to 9ms that is quite the improvement

It is! haha

@alexandrebodin alexandrebodin added this to the 3.4.6 milestone Feb 3, 2021
Copy link
Member

@derrickmehaffy derrickmehaffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexandrebodin alexandrebodin merged commit 42d1d2b into master Feb 3, 2021
@alexandrebodin alexandrebodin deleted the fix/gql-many-many-perf branch February 3, 2021 18:29
@derrickmehaffy
Copy link
Member

This pull request has been mentioned on Strapi Community Forum. There might be relevant details there:

https://forum.strapi.io/t/new-release-strapi-v3-4-6/2631/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

issue: bug Issue reporting a bug source: plugin:graphql Source is plugin/graphql package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants