-
-
Notifications
You must be signed in to change notification settings - Fork 9.2k
Fix some many many perf issues in graphQL #9286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9286 +/- ##
==========================================
- Coverage 35.09% 35.08% -0.02%
==========================================
Files 1308 1308
Lines 14456 14461 +5
Branches 1438 1439 +1
==========================================
Hits 5074 5074
- Misses 8473 8477 +4
- Partials 909 910 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Yeah! I just tried locally and it seems to solve this problem: #8552 (comment) Related: #9020 (comment) |
|
@abdonrd if possible can you run some query speed tests against 3.4.1, 3.4.2, and this fix? I'm hesitant to suggest it's a fix, but a start in the right direction. (Certainly this helps, but I don't have near the data sample size you do to get numbers) |
|
Wow 47 seconds down to 9ms that is quite the improvement |
It is! haha |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
This pull request has been mentioned on Strapi Community Forum. There might be relevant details there: |



Test fix for many many perf issues