Skip to content

Conversation

@alexandrebodin
Copy link
Member

Fix sanitize removing polymorphic relations.

Fix #9308

@alexandrebodin alexandrebodin added issue: bug Issue reporting a bug source: core:strapi Source is core/strapi package labels Feb 3, 2021
@alexandrebodin alexandrebodin added this to the 3.4.6 milestone Feb 3, 2021
@derrickmehaffy
Copy link
Member

Tested with v3.4.5, there is a bit of nested population but we can fix that later as it's too complex to fix right now.

Copy link
Member

@derrickmehaffy derrickmehaffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Feb 3, 2021

Codecov Report

Merging #9310 (62d6cb5) into master (afaf111) will increase coverage by 0.04%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9310      +/-   ##
==========================================
+ Coverage   35.07%   35.12%   +0.04%     
==========================================
  Files        1308     1310       +2     
  Lines       14465    14535      +70     
  Branches     1439     1453      +14     
==========================================
+ Hits         5074     5105      +31     
- Misses       8481     8514      +33     
- Partials      910      916       +6     
Flag Coverage Δ
front 26.65% <ø> (ø)
unit 54.71% <75.00%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...anager/admin/src/components/SelectWrapper/index.js 0.00% <ø> (ø)
packages/strapi-utils/lib/sanitize-entity.js 97.10% <71.42%> (-2.90%) ⬇️
packages/strapi/lib/middlewares/session/index.js 39.28% <100.00%> (ø)
...rapi/lib/core/app-configuration/config-provider.js 70.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfcab11...1947459. Read the comment docs.

@alexandrebodin alexandrebodin merged commit 8d342d3 into master Feb 3, 2021
@alexandrebodin alexandrebodin deleted the fix/related-files branch February 3, 2021 18:28
@derrickmehaffy
Copy link
Member

This pull request has been mentioned on Strapi Community Forum. There might be relevant details there:

https://forum.strapi.io/t/new-release-strapi-v3-4-6/2631/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

issue: bug Issue reporting a bug source: core:strapi Source is core/strapi package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

File upload, related fields returning null

3 participants