Skip to content

Conversation

@petersg83
Copy link
Contributor

May fix #9450

@petersg83 petersg83 force-pushed the fix/fix-knex-version branch from a74da09 to f283575 Compare February 24, 2021 17:21
@codecov
Copy link

codecov bot commented Feb 24, 2021

Codecov Report

Merging #9511 (3eaa75b) into master (e21f06d) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9511      +/-   ##
==========================================
- Coverage   35.96%   35.95%   -0.01%     
==========================================
  Files        1335     1335              
  Lines       14722    14726       +4     
  Branches     1467     1468       +1     
==========================================
  Hits         5295     5295              
- Misses       8511     8514       +3     
- Partials      916      917       +1     
Flag Coverage Δ
front 27.38% <0.00%> (-0.01%) ⬇️
unit 55.54% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...admin/src/containers/ApplicationInfosPage/index.js 70.58% <ø> (ø)
...dmin/src/components/BooleanBox/icons/CTSelected.js 100.00% <ø> (ø)
...in/src/components/BooleanBox/icons/CTUnselected.js 100.00% <ø> (ø)
...dmin/src/components/BooleanBox/icons/STSelected.js 100.00% <ø> (ø)
...in/src/components/BooleanBox/icons/STUnselected.js 100.00% <ø> (ø)
...e-builder/admin/src/components/BooleanBox/index.js 100.00% <ø> (ø)
...-upload/admin/src/containers/SettingsPage/index.js 0.00% <0.00%> (ø)
...sions/admin/src/containers/Roles/ListPage/index.js 0.00% <0.00%> (ø)
packages/strapi-utils/lib/sanitize-entity.js 94.36% <0.00%> (-2.74%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 980ba86...f283575. Read the comment docs.

Copy link
Member

@derrickmehaffy derrickmehaffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but we should run some additional manual tests with these versions on multiple operating systems to ensure there is no bugs

(Was thinking DigitalOcean managed databases and AWS RDS)

@alexandrebodin alexandrebodin added source: core:database Source is core/database package issue: bug Issue reporting a bug labels Feb 24, 2021
@alexandrebodin alexandrebodin added this to the 3.5.2 milestone Feb 24, 2021
Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good initiative

@jorrit
Copy link
Contributor

jorrit commented Feb 24, 2021

Why is sqlite3 pinned to a version older than previously selected?

@alexandrebodin
Copy link
Member

@jorrit it's not if you look at the diff we hadd a specific case to use v5.0.0 of sqlite :)

@jorrit
Copy link
Contributor

jorrit commented Feb 24, 2021

What do you mean? What I saw was that previously it was ^5.0.1 and now it is 5.0.0. I could not read an explanation for this in the diff.

@alexandrebodin
Copy link
Member

the dependency in the getstarted app is not the one used in generated project just our example project. The version used in the generated version is here https://github.com/strapi/strapi/pull/9511/files#diff-c330785d28abd1f2586b6a5afe96f968ac8ac7b69bafad48708729b1818925a3L15-L19

@derrickmehaffy
Copy link
Member

There was a previous issue with SQLite on windows (v5.0.1) that was throwing an error, I had issued a previous patch (modified in that PR @alexandrebodin linked) to temporarily patch the issue.

You can find that issue here: #9120

@derrickmehaffy
Copy link
Member

This pull request has been mentioned on Strapi Community Forum. There might be relevant details there:

https://forum.strapi.io/t/new-release-strapi-v3-5-2/3147/1

This was referenced Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

issue: bug Issue reporting a bug source: core:database Source is core/database package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

problem installing 3.5.0 by npx

5 participants