-
-
Notifications
You must be signed in to change notification settings - Fork 9.2k
Fix knex, pg, mysql versions #9511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a74da09 to
f283575
Compare
Codecov Report
@@ Coverage Diff @@
## master #9511 +/- ##
==========================================
- Coverage 35.96% 35.95% -0.01%
==========================================
Files 1335 1335
Lines 14722 14726 +4
Branches 1467 1468 +1
==========================================
Hits 5295 5295
- Misses 8511 8514 +3
- Partials 916 917 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but we should run some additional manual tests with these versions on multiple operating systems to ensure there is no bugs
(Was thinking DigitalOcean managed databases and AWS RDS)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Good initiative
|
Why is sqlite3 pinned to a version older than previously selected? |
|
@jorrit it's not if you look at the diff we hadd a specific case to use v5.0.0 of sqlite :) |
|
What do you mean? What I saw was that previously it was ^5.0.1 and now it is 5.0.0. I could not read an explanation for this in the diff. |
|
the dependency in the getstarted app is not the one used in generated project just our example project. The version used in the generated version is here https://github.com/strapi/strapi/pull/9511/files#diff-c330785d28abd1f2586b6a5afe96f968ac8ac7b69bafad48708729b1818925a3L15-L19 |
|
There was a previous issue with SQLite on windows (v5.0.1) that was throwing an error, I had issued a previous patch (modified in that PR @alexandrebodin linked) to temporarily patch the issue. You can find that issue here: #9120 |
|
This pull request has been mentioned on Strapi Community Forum. There might be relevant details there: |
May fix #9450