Fix email validation #9584
Fix email validation #9584
Conversation
soupette
added
source: core:admin
Codecov Report
@@ Coverage Diff @@
## master #9584 +/- ##
=======================================
Coverage 35.95% 35.95%
=======================================
Files 1335 1335
Lines 14726 14731 +5
Branches 1468 1468
=======================================
+ Hits 5295 5297 +2
- Misses 8514 8517 +3
Partials 917 917
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| let parseDomainResult = parseDomain(value); | ||
| return parseDomainResult.type === ParseResultType.Listed; | ||
| .test('topLevelDomainValidation', 'Settings.users.validations.email-domain', function(value) { |
There was a problem hiding this comment.
I made the fix but I believe that this is not a wanted logic we want in the admin panel. IMO, this is something that the users should add in their app if they want such validation.
WDYT @alexandrebodin ?
There was a problem hiding this comment.
Not sure what was the wanted behaviour. We can revert it as this is still doable in a lifecycle hook
There was a problem hiding this comment.
I think it would be better to revert it yes
|
I am closing this PR. |
|
This pull request has been mentioned on Strapi Community Forum. There might be relevant details there: https://forum.strapi.io/t/cannot-update-admin-email-on-admin-panel/3285/2 |
Signed-off-by: soupette cyril.lpz@gmail.com
What does it do?
This PR fixes #9554