-
-
Notifications
You must be signed in to change notification settings - Fork 9.2k
Resizing fields in edit view #9898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…tioning, duplicated css, Tooltip.js not used/working anymore) - Added resize function to edit view fields except dynamiczones and components (minSize: 2, maxSize: 12)
Codecov Report
@@ Coverage Diff @@
## master #9898 +/- ##
==========================================
- Coverage 35.90% 27.16% -8.74%
==========================================
Files 1342 1203 -139
Lines 14812 10326 -4486
Branches 1477 562 -915
==========================================
- Hits 5318 2805 -2513
+ Misses 8575 7031 -1544
+ Partials 919 490 -429
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
This pull request has been mentioned on Strapi Community Forum. There might be relevant details there: https://forum.strapi.io/t/columns-in-content-manager-detail-view/1011/12 |
|
This pull request has been mentioned on Strapi Community Forum. There might be relevant details there: https://forum.strapi.io/t/change-width-of-fields-on-edit-page/181/4 |
|
Any movement on this? This would be a great feature to have in the CMS and would be especially helpful for Content Managers in my organization. |
|
We would also be helped greatly if this feature gets released. |
|
I'm currently using it withing /extensions directory but one single file is not overrideable and that is the one which will reset all resized fields on "yarn build". |
|
@web-mi the settings being reset after server restart is a deal breaker. Currently we apply a SQL migration that contains the JSON for the edit view, but it is pointless because it gets reset after a restart... |
|
Yes. Thats because its better to get the review done. Then the reset problem should be gone. ;-) |
|
+1 |
|
What is status of this pr? Would be a awesome feature for strapi. |
|
|
Hello, Thanks @web-mi for the PR and everyone else for the interest 🙂 We really like this feature and the possibilities it introduces to customize the view. Though, for the moment we have to wait a bit before fully evaluating the possibility to merge it. And we probably won't be able to merge it as it is. And that for 2 main reasons:
We totally want to add more flexibility and customization possibilities in the Edit view, it's in our plans and this PR is a good starting point, but we'll have to work on it together. So let's wait until the end of the Quarter, once the v4 and the Design System are released, and see how to make it work 🙂 |
|
And I feel questions on the v4 coming haha 😄 so here's some info:
|
|
Hi 👋 PS I would really love to see this refactored for the v4. This PR is awesome if we could add it. |
|
I was actually kind of hoping that v4 will have this functionality already included. At this point, is the author (@web-mi) willing to refactor this for v4, or should someone else take over? |
If anyone else wants to take over there is no reason to hold out for the original author unless they speak up. |
|
Hi together, |
I'm sorry to hear that and I know we certainly did not do the best we could on getting this and #9865 looked at in a reasonable amount of time and I'll be sharing that feedback with the team to hopefully not let this happen again in the future. |
What does it do?
Why is it needed?
Using 50% of the remaining space for a single dropdown or radio button makes editing complicated because much space is wasted.
How to test it?
Edit view of any component. A new button is shown at the end of the fields. By dragging the element the field could be resized to any size between 2/12 and 12/12. 2/12 instead of 1/12 because 1/12 is to small for description and buttons. Maybe someone has an idea how to handle too small elements.
Related issue(s)/PR(s)
Issues: #8094, #8950
Strapi Community Discussion:
https://forum.strapi.io/t/change-width-of-fields-on-edit-page/181
https://forum.strapi.io/t/columns-in-content-manager-detail-view/1011/2