From 7acbbe68c5bae5d43d501253b2d64c23dee8e736 Mon Sep 17 00:00:00 2001 From: Simon R Jones Date: Fri, 10 Feb 2023 09:30:14 +0000 Subject: [PATCH 1/4] Update install docs --- README.md | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/README.md b/README.md index 54e698a..ca2706f 100644 --- a/README.md +++ b/README.md @@ -6,6 +6,9 @@ Includes: * Twig helpers * HTTP cache for full-page caching +## Status +Please note this software is in development, usage may change before the 1.0 release. + ## Requirements * PHP 7.4+ @@ -14,6 +17,12 @@ Includes: ## Installation +Install via Composer: + +``` +composer require strata/symfony-frontend:^0.8 +``` + See [installation](docs/installation.md) ## Documentation From 32869fe1cfbec91268a5fef3d4153059e73615f7 Mon Sep 17 00:00:00 2001 From: Simon R Jones Date: Fri, 10 Feb 2023 12:06:54 +0000 Subject: [PATCH 2/4] Update CI to test against PHP 7.4 only for v0.8.x --- .github/workflows/php.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/php.yml b/.github/workflows/php.yml index c1eecf5..dc89e40 100644 --- a/.github/workflows/php.yml +++ b/.github/workflows/php.yml @@ -11,7 +11,7 @@ jobs: strategy: matrix: - php-versions: ['7.4', '8.0'] + php-versions: ['7.4'] runs-on: ubuntu-latest @@ -46,7 +46,7 @@ jobs: - name: Install dependencies if: steps.composer-cache.outputs.cache-hit != 'true' - run: composer install --prefer-dist --no-progress --no-suggest + run: composer install --prefer-dist --no-progress - name: Code lint PHP files run: ./vendor/bin/phplint From cd7ac8f665ccb0eedbd1ef64b84c1b493eb1cd08 Mon Sep 17 00:00:00 2001 From: Simon R Jones Date: Fri, 10 Feb 2023 12:10:07 +0000 Subject: [PATCH 3/4] Do not install composer plugins (causes error on CI) --- composer.json | 3 +++ 1 file changed, 3 insertions(+) diff --git a/composer.json b/composer.json index 2f56013..7c566b1 100644 --- a/composer.json +++ b/composer.json @@ -33,5 +33,8 @@ "squizlabs/php_codesniffer": "^3.5", "phpunit/phpunit": "^9.5", "symfony/test-pack": "^1.0" + }, + "config": { + "allow-plugins": false } } From 4480dffb84fed69544e30d6b392f95ecfe3f7b45 Mon Sep 17 00:00:00 2001 From: Simon R Jones Date: Fri, 10 Feb 2023 12:14:24 +0000 Subject: [PATCH 4/4] Code standards --- src/DataCollector/StrataDataCollector.php | 2 ++ src/EventSubscriber/ResponseHelperEventSubscriber.php | 1 - src/EventSubscriber/ResponseTagsEventSubscriber.php | 1 - 3 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/DataCollector/StrataDataCollector.php b/src/DataCollector/StrataDataCollector.php index 991defe..5c427f1 100644 --- a/src/DataCollector/StrataDataCollector.php +++ b/src/DataCollector/StrataDataCollector.php @@ -1,5 +1,7 @@ helper->apply($event->getResponse()); } - } diff --git a/src/EventSubscriber/ResponseTagsEventSubscriber.php b/src/EventSubscriber/ResponseTagsEventSubscriber.php index b329235..fd83b25 100644 --- a/src/EventSubscriber/ResponseTagsEventSubscriber.php +++ b/src/EventSubscriber/ResponseTagsEventSubscriber.php @@ -60,5 +60,4 @@ public function onKernelResponse(ResponseEvent $event) // Add custom response header (since some cache proxies strip cache tag header) $event->getResponse()->headers->set(self::TAGS_HEADER_NAME, $this->responseTagger->getTagsHeaderValue()); } - }