Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also .

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also .
Choose a Base Repository
strategist922/pycassa
eevans/pycassa
pycassa/pycassa
DanHoerst/pycassa
DataDog/pycassa
DikangGu/pycassa
EmergingThreats/pycassa
JioCloudCompute/pycassa
SPRIME01/pycassa
SethCLong/pycassa
StyXman/pycassa
XN137/pycassa
YangXinNewlife/pycassa
YinYanfei/pycassa
a13x/pycassa
aalexander/pycassa
ace-wu/pycassa
adnam/pycassa
ahmed26/pycassa
amorton/pycassa
amxn/pycassa
animeshinvinci/pycassa
anisnasir/pycassa
artgibson/pycassa
babo/pycassa
bblay/pycassa
bjornedstrom/pycassa
blair/pycassa
bmat06/pycassa
bobveznat/pycassa
bshanks/pycassa
bwhite/pycassa
c3h3/pycassa
carlopires/pycassa
carriercomm/pycassa
caruccio/pycassa
ccarollo/pycassa
chondm/pycassa
cnhacks/pycassa
david-huber/pycassa
decbis/pycassa
delciotorres/pycassa
devdazed/pycassa
devendermishrajio/pycassa
devmario/pycassa
dfb/pycassa
dkong/pycassa
dkuebric/pycassa
dln/pycassa
dmcgowan/pycassa
duanshuaimin/pycassa
ebocek/pycassa
edevil/pycassa
elephantum/pycassa
enki/pycassa
ericjster/pycassa
eruizgarcia/pycassa
ezy023/pycassa
f0rk/pycassa
fkanchwala/pycassa
formspring/pycassa
forsberg/pycassa
gdoermann/pycassa
gjcourt/pycassa
gmcquillan/pycassa
gustavopinto/pycassa
h4ck3rm1k3/pycassa
hellcoderz/pycassa
hidd3ncod3s/pycassa
hppj/pycassa
iamaleksey/pycassa
ilovejs/pycassa
jalandip/pycassa
jc0n/pycassa
jeffjirsa/pycassa
jeromatron/pycassa
jhseu/pycassa
jiocloud-tools/pycassa
johnrfrank/pycassa
jorgeecardona/pycassa
justecorruptio/pycassa
katzj/pycassa
ketralnis/pycassa
koepsell/pycassa
kurtjx/pycassa
kxynos/pycassa
kylemcc/pycassa
linpingchuan/pycassa
ljsking/pycassa
lorenhsu1128/pycassa
lukearno/pycassa
lzglee/pycassa
mailmahee/pycassa
maraca/pycassa
marcinn/pycassa
mdennis/pycassa
michaelhood/pycassa
mindis/pycassa
mitchellzen/pycassa
mitodl/pycassa
mlifemaker/pycassa
mrkeng/pycassa
natasha-aleksandrova/pycassa
pbutler/pycassa
pelotoncycle/pycassa
phanirajl/pycassa
phuongcsa/pycassa
pilate/pycassa
pista329/pycassa-thriftpy
pombredanne/pycassa
prodigeni/pycassa
pulseenergy/pycassa
rbranson/pycassa
refnode/pycassa
rkomartin/pycassa
robingustafsson/pycassa
rudimk/pycassa
rumpelt/pycassa
samuraisam/pycassa
savinos/pycassa
sbadia/pycassa
schevalier/pycassa
scv119/pycassa
sebastibe/pycassa
shubham2706/pycassa
smajithia/pycassa
somia/pycassa
spladug/pycassa
stantonk/pycassa
svisser/pycassa
tedcarroll/pycassa
termie/pycassa
thaingo/pycassa
thelastpickle/pycassa
thepaul/pycassa
trhowe/pycassa
truesef-dev/pycassa
tsweany/pycassa
umairmufti/pycassa
umeier/pycassa
volkangurel/pycassa
wfxiang08/pycassa
yienyien/pycassa
zhuzhichaoTM/pycassa
ztianjin/pycassa
Nothing to show
Choose a base branch
Nothing to show
...
Choose a Head Repository
strategist922/pycassa
eevans/pycassa
pycassa/pycassa
DanHoerst/pycassa
DataDog/pycassa
DikangGu/pycassa
EmergingThreats/pycassa
JioCloudCompute/pycassa
SPRIME01/pycassa
SethCLong/pycassa
StyXman/pycassa
XN137/pycassa
YangXinNewlife/pycassa
YinYanfei/pycassa
a13x/pycassa
aalexander/pycassa
ace-wu/pycassa
adnam/pycassa
ahmed26/pycassa
amorton/pycassa
amxn/pycassa
animeshinvinci/pycassa
anisnasir/pycassa
artgibson/pycassa
babo/pycassa
bblay/pycassa
bjornedstrom/pycassa
blair/pycassa
bmat06/pycassa
bobveznat/pycassa
bshanks/pycassa
bwhite/pycassa
c3h3/pycassa
carlopires/pycassa
carriercomm/pycassa
caruccio/pycassa
ccarollo/pycassa
chondm/pycassa
cnhacks/pycassa
david-huber/pycassa
decbis/pycassa
delciotorres/pycassa
devdazed/pycassa
devendermishrajio/pycassa
devmario/pycassa
dfb/pycassa
dkong/pycassa
dkuebric/pycassa
dln/pycassa
dmcgowan/pycassa
duanshuaimin/pycassa
ebocek/pycassa
edevil/pycassa
elephantum/pycassa
enki/pycassa
ericjster/pycassa
eruizgarcia/pycassa
ezy023/pycassa
f0rk/pycassa
fkanchwala/pycassa
formspring/pycassa
forsberg/pycassa
gdoermann/pycassa
gjcourt/pycassa
gmcquillan/pycassa
gustavopinto/pycassa
h4ck3rm1k3/pycassa
hellcoderz/pycassa
hidd3ncod3s/pycassa
hppj/pycassa
iamaleksey/pycassa
ilovejs/pycassa
jalandip/pycassa
jc0n/pycassa
jeffjirsa/pycassa
jeromatron/pycassa
jhseu/pycassa
jiocloud-tools/pycassa
johnrfrank/pycassa
jorgeecardona/pycassa
justecorruptio/pycassa
katzj/pycassa
ketralnis/pycassa
koepsell/pycassa
kurtjx/pycassa
kxynos/pycassa
kylemcc/pycassa
linpingchuan/pycassa
ljsking/pycassa
lorenhsu1128/pycassa
lukearno/pycassa
lzglee/pycassa
mailmahee/pycassa
maraca/pycassa
marcinn/pycassa
mdennis/pycassa
michaelhood/pycassa
mindis/pycassa
mitchellzen/pycassa
mitodl/pycassa
mlifemaker/pycassa
mrkeng/pycassa
natasha-aleksandrova/pycassa
pbutler/pycassa
pelotoncycle/pycassa
phanirajl/pycassa
phuongcsa/pycassa
pilate/pycassa
pista329/pycassa-thriftpy
pombredanne/pycassa
prodigeni/pycassa
pulseenergy/pycassa
rbranson/pycassa
refnode/pycassa
rkomartin/pycassa
robingustafsson/pycassa
rudimk/pycassa
rumpelt/pycassa
samuraisam/pycassa
savinos/pycassa
sbadia/pycassa
schevalier/pycassa
scv119/pycassa
sebastibe/pycassa
shubham2706/pycassa
smajithia/pycassa
somia/pycassa
spladug/pycassa
stantonk/pycassa
svisser/pycassa
tedcarroll/pycassa
termie/pycassa
thaingo/pycassa
thelastpickle/pycassa
thepaul/pycassa
trhowe/pycassa
truesef-dev/pycassa
tsweany/pycassa
umairmufti/pycassa
umeier/pycassa
volkangurel/pycassa
wfxiang08/pycassa
yienyien/pycassa
zhuzhichaoTM/pycassa
ztianjin/pycassa
Nothing to show
Choose a head branch
Nothing to show
Checking mergeability… Don’t worry, you can still create the pull request.
This comparison is big! We’re only showing the most recent 250 commits
Commits on Mar 09, 2012
Commits on Mar 14, 2012
Support for defining CompositeTypes with custom inner types.
E.g.: Given the following custom type:

Class MyDateType(CassandraType):
	@staticmethod
	def pack(v, *args, **kwargs):
		"""custom pack implementation"""

	@staticmethod
	def unpack(v, *args, **kwargs):
		"""custom unpack implementation"""

You can now do the following:

	c = CompositeType(MyDateType, LongType)

And the following:

	cf = ColumnFamily(pool, 'MyColumnFamily')
	cf.column_name_class = CompositeType(MyDateType, LongType)
Commits on Mar 16, 2012
Commits on Mar 17, 2012
Merge pull request #128 from pelotasplus/master
fix issue with empty server list
Commits on Mar 18, 2012
Commits on Mar 19, 2012
Commits on Mar 23, 2012
Commits on Mar 24, 2012
Merge pull request #127 from caruccio/bb29fe65d1421cfff613dbbfa8ffa0f…
…be2e01f89

RPM Install script to build under CentOS
Commits on Mar 25, 2012
Commits on Mar 28, 2012
Commits on Apr 16, 2012
Match C* sorting of TimeUUIDs when timestamps tie
Cassandra uses a signed byte array comparison to break
ties when two UUIDs have matching timestamp components.
The slice end templates we use to make the lowest or highest
possible UUID with the same timestamp needed to be changed
in order to match this.
Commits on Apr 17, 2012
Commits on Apr 23, 2012
Commits on Apr 24, 2012
Merge pull request #134 from bbangert/master
Use gevent Queue when gevent monkey-patching is used.
Avoid float precision issues with UUID timestamps
Fixes #135 by using microseconds as an intermediate form
in place of nanoseconds, which were causing precision loss.
Commits on Apr 25, 2012
Commits on Apr 26, 2012
Merge pull request #133 from caruccio/master
forcing setup.py to optimize all files
Commits on Apr 30, 2012
Pack column names in col validator dict
Fixes #124

When the dict was set up by pycassa, it would use the
column names from the CfDef's column_metadata, which are
already packed.  However, when users tried to change these
manually, they wouldn't supply a packed version.
Commits on May 03, 2012
Commits on May 04, 2012
Fix xget paging for non-string comparators
column_start and column_finish were being packed twice,
which broke when the comparator had a non-idempotent pack
method.

Fixes #139
Commits on May 11, 2012
Commits on May 15, 2012
Commits on May 16, 2012
Merge pull request #141 from kylemcc/master
Added batch_insert to ColumnFamilyMap + minor convenience change
Commits on May 21, 2012
Commits on May 23, 2012
Commits on May 24, 2012
Commits on May 25, 2012
Merge pull request #147 from zachhuff386/master
Missing AuthenticationException and AuthorizationException
Commits on May 26, 2012
Handle timezones more cleanly when autopacking/unpacking.
Previously, datetime objects were assumed to be in local time. Now,
naive objects are expected to be in UTC and timezone-aware objects
will be converted to UTC for storage.
Commits on May 29, 2012
Commits on May 31, 2012
Commits on Jun 09, 2012
Merge pull request #152 from robingustafsson/master
Support for counter columns in xget
Commits on Jun 19, 2012
Commits on Jun 21, 2012
Commits on Jun 28, 2012
Commits on Jul 02, 2012
Add missing SkipTest import
This was raised while running tests against old C* 0.8.x versions.
Commits on Jul 17, 2012
adjust version check - C* 1.1.0 reports 19.30.0 via `describe_version()`
but 19.20.0 via `version` as `c11.constants.VERSION` is the newer `19.32.0`
Commits on Jul 18, 2012
Let the pool retry TTransportException instead of the general TException
With the c11 thrift API update, all exceptions in ttypes inherit from
TException instead of Exception. This change restores the old behavior and
does not retry any of: NotFoundException, InvalidRequestException,
AuthenticationException, AuthorizationException, SchemaDisagreementException

Compared to pycassa 1.6.0 TProtocolException is no longer retried either.
Commits on Jul 23, 2012
Commits on Jul 24, 2012
Commits on Aug 10, 2012
Commits on Aug 19, 2012
Commits on Aug 20, 2012
Commits on Sep 04, 2012
Commits on Sep 07, 2012
Avoid cyclic deps when installing
If the pycassa module is imported in setup.py,
it will currently end up trying to import thrift. This
causes issues when installing pycassa, as thrift may not
yet be available.
Commits on Sep 21, 2012
Introduce SASL transport support
While the TSaslClientTransport is not in mainline thrift,
it will be bundled in the connection module.

The user may now provide a transport_factory function that
will be used to create transports for new connections. As a
convenience, the pycassa.connection.make_sasl_transport_factor()
function will capture SASL parameters in a closure and return
a factory function, but the user is also free to define their
own factory function.
Commits on Sep 24, 2012
Commits on Sep 25, 2012
Commits on Oct 09, 2012
Commits on Oct 17, 2012
Commits on Oct 18, 2012
Commits on Oct 26, 2012
Commits on Nov 05, 2012
Commits on Nov 08, 2012
Commits on Nov 09, 2012
Commits on Nov 10, 2012
Commits on Nov 14, 2012
Commits on Dec 05, 2012
Look at object parents when mapping to column families
Using self.cls.__dict__ only looks at the members of the class and
not any parents.  Better to use inspect.getmembers() for this
purpose and get the full hierarchy
Merge pull request #181 from katzj/cfmap-objects-inherit
Look at object parents when mapping to column families
Commits on Jan 08, 2013
Commits on Jan 11, 2013
Merge pull request #183 from umairmufti/develop
Added support for DynamicCompositeType.
Commits on Jan 18, 2013
Commits on Jan 19, 2013
Commits on Jan 24, 2013
Adding unit tests for stubs that ensure the APIs and functionality li…
…ne up. Added some missing functionality to the stub objects as well, to make it more closely line up to the API.
Commits on Jan 25, 2013
Set keyspace on conn after (potentially) logging in
Authenticators may require that users be logged in prior to
executing set_keyspace() now in order to avoid leaking info
about what keyspaces exist.
Commits on Jan 28, 2013
Commits on Jan 31, 2013
Merge pull request #185 from eventbrite/stubs
Adding stub objects for ColumnFamily, ConnectionPool, and SystemManager
Commits on Feb 12, 2013
Commits on Feb 13, 2013
Commits on Feb 14, 2013
Commits on Feb 15, 2013
Merge pull request #189 from edevil/master
Reduce critical section protected by global lock
Commits on Feb 25, 2013
Commits on Feb 26, 2013
Remove download_url from setup.py
Github stopped providing download hosting, and it was
decided on the user ML that there's no need to set
download_url at all -- the normal pypi tarball will
suffice:
https://groups.google.com/forum/?fromgroups#!topic/pycassa-discuss/oQ_l_coZDFg
Commits on Mar 12, 2013
fix example code in Getting a ColumnFamily
the "pycassa" module is neither imported nor needed
Commits on Mar 15, 2013
Merge pull request #192 from termie/master
fix example code in Getting a ColumnFamily
Commits on Apr 10, 2013
Commits on Apr 11, 2013
Commits on Apr 25, 2013
Merge pull request #195 from david-huber/master
Add column_start and column_finish support to pycassa.contrib.stubs.ColumnFamilyStub
Commits on Apr 30, 2013
Commits on May 02, 2013
Commits on May 03, 2013
Merge pull request #198 from david-huber/master
Adding column_count and column_reversed support to ColumnFamilyStub.get and ColumnFamityStub.multiget
Commits on May 06, 2013
Merge pull request #197 from edevil/master
Add "include_ttl" parameter that allows column TTL's to be returned as well
Commits on May 28, 2013
Commits on Jun 20, 2013
Commits on Jul 03, 2013
When a connection is recycled, and the pool is full, the old connecti…
…on would be disposed twice.

This would happen because the Queue.Full exception would be raised, and so "conn"" would be the old connection that has already been disposed. This connection would again be disposed due to the Full exception.
Merge pull request #205 from edevil/DisposeRecycled
When a connection is recycled, and the pool is full, the old connection would be disposed twice.
Commits on Jul 17, 2013
Commits on Jul 19, 2013
Commits on Jul 20, 2013
Commits on Jul 26, 2013
Use a lock around all updates to shared state.
Prevent closed connections from ending up in the pool (Mutator uses "return_to_pool"). Since current_conns has already been decremented, the pool would reach a state where a new connection was always opened but could not be put in the queue since it was full.
Commits on Jul 29, 2013
Commits on Jul 30, 2013
Commits on Jul 31, 2013
Commits on Aug 02, 2013
Commits on Aug 05, 2013
Merge pull request #213 from edevil/MissingDec
Make sure connection count is decremented as we are disposing connection...
Commits on Aug 16, 2013
Commits on Sep 17, 2013
Fix docstring for start/finish_token formats
The tokens only need to be hex encoded when using
ByteOrderedPartitioner.
Commits on Oct 03, 2013
Commits on Oct 17, 2013
Commits on Oct 18, 2013
Commits on Nov 06, 2013
Commits on Nov 29, 2013
remove returns timestamp
Stub should behave as the "real" thing.
Commits on Jan 10, 2014
Commits on Jan 14, 2014
Commits on Feb 04, 2014
Commits on Feb 06, 2014
Commits on Feb 20, 2014
Commits on Mar 21, 2014
Corrected StatsLogger example.
It suggested that the stats would be a property of the ConnectionPool.
Commits on Apr 07, 2014
[debian] Bump to 1.11.0 and fix lintian errors
Lintian fixes:
- usused-build-dependency-on-cdbs
- *-nmu (non maintainer upload)
- latest-debian-changelog-entry-changed-to-native
- missing-license-paragraph-in-dep5-copyright
Commits on Apr 10, 2014
Merge pull request #227 from thelastpickle/issue-1
Add token map to system_manager.
Merge pull request #231 from sbadia/debian
[debian] Bump to 1.11.0 and fix lintian errors
Merge pull request #230 from decbis/master
Corrected StatsLogger example.
[debian] Add depends on libjs-underscore for pycassa-doc
Fix lintian warning « embedded-javascript-library »
for usr/share/doc/pycassa-doc/manual/_static/underscore.js
Refer to Debian Policy Manual section 4.13 (Convenience copies of code)
[debian] Add registration into doc-base
possible-documentation-but-no-doc-base-registration
Commits on Apr 11, 2014
Commits on Apr 21, 2014
Commits on Apr 22, 2014
Merge pull request #234 from dkong/fix_doc_typo
Fix typos in "Composite Types" doc
Commits on May 02, 2014
Commits on Aug 07, 2014
Commits on Aug 08, 2014
Merge pull request #239 from dfb/master
fixed minor docstring typos
Commits on Jan 07, 2015
Commits on Jan 17, 2017
Showing with 17,048 additions and 7,320 deletions.
  1. +5 −0 .gitignore
  2. +23 −0 .travis.yml
  3. +24 −0 AUTHORS
  4. +766 −0 CHANGES
  5. +87 −323 README.mkd
  6. +44 −0 debian/changelog
  7. +1 −0 debian/compat
  8. +51 −0 debian/control
  9. +52 −0 debian/copyright
  10. +12 −0 debian/pycassa-doc.doc-base
  11. +1 −0 debian/pycassa-doc.install
  12. +60 −0 debian/pycassaShell.1
  13. +7 −0 debian/python-pycassa.README.Debian
  14. +2 −0 debian/python-pycassa.docs
  15. +1 −0 debian/python-pycassa.manpages
  16. +33 −0 debian/rules
  17. +1 −0 debian/source/format
  18. +3 −0 debian/watch
  19. BIN doc/_static/favicon.ico
  20. +9 −4 doc/api/index.rst
  21. +75 −0 doc/api/pycassa.rst
  22. +16 −3 doc/api/pycassa/batch.rst
  23. +64 −3 doc/api/pycassa/columnfamily.rst
  24. +18 −3 doc/api/pycassa/columnfamilymap.rst
  25. +0 −5 doc/api/pycassa/connection.rst
  26. +34 −0 doc/api/pycassa/contrib/stubs.rst
  27. +17 −3 doc/api/pycassa/index.rst
  28. +0 −5 doc/api/pycassa/logger.rst
  29. +5 −0 doc/api/pycassa/logging/pool_stats_logger.rst
  30. +5 −0 doc/api/pycassa/logging/pycassa_logger.rst
  31. +50 −3 doc/api/pycassa/pool.rst
  32. +6 −0 doc/api/pycassa/system_manager.rst
  33. +20 −3 doc/api/pycassa/types.rst
  34. +5 −0 doc/api/pycassa/util.rst
  35. +81 −0 doc/assorted/column_family_map.rst
  36. +91 −0 doc/assorted/composite_types.rst
  37. +14 −0 doc/assorted/index.rst
  38. +131 −0 doc/assorted/pycassa_shell.rst
  39. +40 −0 doc/assorted/secondary_indexes.rst
  40. +42 −0 doc/assorted/super_columns.rst
  41. +54 −0 doc/assorted/time_uuid.rst
  42. +887 −7 doc/changelog.rst
  43. +14 −8 doc/conf.py
  44. +82 −0 doc/development.rst
  45. +34 −26 doc/index.rst
  46. +19 −1 doc/installation.rst
  47. +0 −377 doc/sphinxtogithub.py
  48. +196 −278 doc/tutorial.rst
  49. +46 −0 doc/using_with/celery.rst
  50. +12 −0 doc/using_with/eventlet.rst
  51. +9 −0 doc/using_with/index.rst
  52. +9 −0 doc/using_with/multiprocessing.rst
  53. +212 −230 ez_setup.py
  54. +9 −5 pycassa/__init__.py
  55. +141 −70 pycassa/batch.py
  56. +4,600 −1,018 pycassa/cassandra/Cassandra.py
  57. +5 −4 pycassa/cassandra/constants.py
  58. +1,699 −246 pycassa/cassandra/ttypes.py
  59. +964 −583 pycassa/columnfamily.py
  60. +181 −252 pycassa/columnfamilymap.py
  61. +187 −261 pycassa/connection.py
  62. 0 pycassa/contrib/__init__.py
  63. +256 −0 pycassa/contrib/stubs.py
  64. +59 −15 pycassa/index.py
  65. +0 −127 pycassa/logger.py
  66. 0 pycassa/logging/__init__.py
  67. +89 −0 pycassa/logging/pool_logger.py
  68. +138 −0 pycassa/logging/pool_stats_logger.py
  69. +110 −0 pycassa/logging/pycassa_logger.py
  70. +406 −0 pycassa/marshal.py
  71. +585 −1,052 pycassa/pool.py
  72. +0 −187 pycassa/queue.py
  73. +468 −0 pycassa/system_manager.py
  74. +287 −92 pycassa/types.py
  75. +205 −38 pycassa/util.py
  76. +258 −30 pycassaShell
  77. +5 −0 rpm-install-script.sh
  78. +73 −20 setup.py
  79. +6 −7 tests/README
  80. +32 −0 tests/__init__.py
  81. +0 −499 tests/cassandra.yaml
  82. 0 tests/contrib/__init__.py
  83. +237 −0 tests/contrib/stubs.py
  84. +0 −40 tests/log4j-server.properties
  85. +1,108 −341 tests/test_autopacking.py
  86. +93 −62 tests/test_batch_mutation.py
  87. +0 −194 tests/test_column_family_on_pool.py
  88. +595 −153 tests/test_columnfamily.py
  89. +190 −144 tests/test_columnfamilymap.py
  90. +0 −32 tests/test_connection.py
  91. +304 −566 tests/test_connection_pooling.py
  92. +133 −0 tests/test_pool_logger.py
  93. +140 −0 tests/test_system_manager.py
  94. +15 −0 tests/util.py
View
@@ -1,7 +1,12 @@
*.pyc
*.swp
*.swo
+*.diff
+bin/
build/
doc/_build
dist/
+include/
+lib/
+man/
pycassa.egg-info/
View
@@ -0,0 +1,23 @@
+language: python
+python:
+ - "2.6"
+ - "2.7"
+
+notifications:
+ email:
+ - hanno@hannosch.eu
+ - pycassa.maintainer@gmail.com
+
+services:
+ - cassandra
+
+before_script:
+ # give some more time for Cassandra to finish startup and actually test it
+ - sleep 10
+ - sudo service cassandra status
+
+install:
+ - python setup.py develop
+
+script:
+ - nosetests -v
View
24 AUTHORS
@@ -7,3 +7,27 @@ Eric Evans
Seth Long
Whitney Sorenson
Tyler Hobbs
+Jon Hermes
+Carlo Pires
+Bjorn Edstrom
+Adam Lowry
+Wojciech 'KosciaK' Pietrzok
+Joaquin Casares
+Savino Sguera
+Dan Kuebrich
+Paul Cannon
+Kay Sackey
+Alexey Smolsky
+Samuel Sutch
+Aaron Morton
+Ian Danforth
+John Calixto
+Justin Plock
+Carlo Cabanilla
+Bayle Shanks
+Hanno Schlichting
+Ryan P. Kelley
+Aleksey Yeschenko
+Jeremy Katz
+Umair Mufti
+Eyal Reuveni
Oops, something went wrong.

Showing you all comments on commits in this comparison.

@lelit

This comment has been minimized.

Show comment Hide comment
@lelit

lelit Jun 21, 2012

Is this right? A few lines up there's already a cfs.sort(), and at first sight that seems enough... Moreover, cfs seems a list of strings, not of CF instances...

lelit commented on 67aef98 Jun 21, 2012

Is this right? A few lines up there's already a cfs.sort(), and at first sight that seems enough... Moreover, cfs seems a list of strings, not of CF instances...

@thobbs

This comment has been minimized.

Show comment Hide comment
@thobbs

thobbs Jun 21, 2012

Owner

Ah, you are correct, I was too hasty with that one.

Owner

thobbs commented on 67aef98 Jun 21, 2012

Ah, you are correct, I was too hasty with that one.

@trinaryouroboros

This comment has been minimized.

Show comment Hide comment
@trinaryouroboros

trinaryouroboros Jul 20, 2013

Cool beans

Cool beans