diff --git a/Gemfile b/Gemfile index ff602f025..344331f1a 100644 --- a/Gemfile +++ b/Gemfile @@ -4,6 +4,7 @@ gemspec if true group :test do + gem 'pry' gem 'guard' gem 'guard-test' end diff --git a/test/helper.rb b/test/helper.rb index 053990062..429e328eb 100644 --- a/test/helper.rb +++ b/test/helper.rb @@ -55,10 +55,6 @@ def manual_notify_ignored end end -class AirbrakeController < ActionController::Base - include TestMethods -end - class Test::Unit::TestCase def request(action = nil, method = :get, user_agent = nil, params = {}) @request = ActionController::TestRequest.new diff --git a/test/notifier_test.rb b/test/notifier_test.rb index 6426178eb..603603805 100644 --- a/test/notifier_test.rb +++ b/test/notifier_test.rb @@ -1,4 +1,4 @@ -require File.dirname(__FILE__) + '/helper' +require File.expand_path( File.join(File.dirname(__FILE__), 'helper') ) class NotifierTest < Test::Unit::TestCase diff --git a/test/sender_test.rb b/test/sender_test.rb index 805768be3..08c5e392c 100644 --- a/test/sender_test.rb +++ b/test/sender_test.rb @@ -1,4 +1,4 @@ -require File.dirname(__FILE__) + '/helper' +require File.expand_path( File.join(File.dirname(__FILE__), 'helper') ) class SenderTest < Test::Unit::TestCase @@ -64,30 +64,30 @@ def stub_http(options = {}) assert_equal "3799307", send_exception(:secure => false) end - context "exceptions" do + context "when encountering exceptions: " do context "HTTP connection setup problems" do should "not be rescued" do - http = stub(:new => NoMemoryError.new) - proxy = stub(:new => http) + proxy = stub() + proxy.stubs(:new).raises(NoMemoryError) Net::HTTP.stubs(:Proxy => proxy) - assert_raise do + assert_raise NoMemoryError do build_sender.send(:setup_http_connection) end end should "be logged" do - http = stub(:new => NoMemoryError.new) - proxy = stub(:new => http) + proxy = stub() + proxy.stubs(:new).raises(RuntimeError) Net::HTTP.stubs(:Proxy => proxy) sender = build_sender - - assert_raise do - sender.expects(:log).with(:error, includes('Failure initializing the HTTP connection')) - + sender.expects(:log).with(:error, includes('Failure initializing the HTTP connection')) + + assert_raise RuntimeError do sender.send(:setup_http_connection) end + end end @@ -102,7 +102,7 @@ def stub_http(options = {}) should "return nil no matter what" do sender = build_sender - sender.stubs(:setup_http_connection).raises(SystemExit.new) + sender.stubs(:setup_http_connection).raises(LocalJumpError) assert_nothing_thrown do assert_nil sender.send_to_airbrake("stuff")