Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix push backup docs config #22

Merged
merged 2 commits into from Jun 13, 2012

Conversation

Projects
None yet
2 participants
Contributor

mncaudill commented Jun 13, 2012

Just fixed a typo with the account backup info page and added the 2 new config options to enable PuSH backup to config.php.example.

@straup straup pushed a commit that referenced this pull request Jun 13, 2012

Aaron Straup Cope Merge pull request #22 from mncaudill/fix-push-backup-docs-config
Fix push backup docs config
a35fd89

@straup straup merged commit a35fd89 into straup:master Jun 13, 2012

Owner

straup commented Jun 13, 2012

Actually, I am going to remove those two new configs because they are already there. Specifically:

https://github.com/straup/parallel-flickr/blob/master/www/include/config.php.example#L148

https://github.com/straup/parallel-flickr/blob/master/www/include/config.php.example#L167

Are you reacting to the addition of the features_is|ensure_enabled functions which accepts a truncated version of the feature flag? If so then that's probably a good indication of Creeping Magic and I will remove the code that appends missing "feature_enabled_" prefixes:

https://github.com/straup/parallel-flickr/blob/master/www/include/lib_features.php#L12

Contributor

mncaudill commented Jun 13, 2012

I think this was more of had another issue and then I noticed those configs in the README it was there so I added it, but regardless the feature_enabled is actually pretty nice sugar for feature flags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment