Skip to content

chore(ci): pin action versions to hashes - #645

Merged
lwasser merged 2 commits into
stravalib:mainfrom
miketheman:miketheman/pin-action-versions
Jun 18, 2025
Merged

lwasser merged 2 commits into
stravalib:mainfrom
miketheman:miketheman/pin-action-versions

Conversation

@miketheman

Copy link
Copy Markdown
Contributor

Description

Increase repository security by pinning GitHub Actions to hashes, to minimize the ability for the underlying author to change the tag of the release without the user knowing about it.

Surfaced via zizmor
Ref: https://docs.zizmor.sh/audits/#unpinned-uses

Type of change

Select the statement best describes this pull request.

  • This is a infrastructure update (docs, ci, etc)

Does your PR include tests

If you are fixing a bug or adding a feature, we appreciate (but do not require)
tests to support whatever fix of feature you're implementing.

  • This change doesn't require tests

Surfaced via zizmor
Ref: https://docs.zizmor.sh/audits/#unpinned-uses

Signed-off-by: Mike Fiedler <miketheman@gmail.com>
@lwasser

lwasser commented Jun 18, 2025

Copy link
Copy Markdown
Collaborator

@all-contributors please add @miketheman for code, review, security

@allcontributors

Copy link
Copy Markdown
Contributor

@lwasser

I've put up a pull request to add @miketheman! 🎉

@codecov

codecov Bot commented Jun 18, 2025 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.77%. Comparing base (303c3df) to head (6bae953).
⚠️ Report is 28 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #645   +/-   ##
=======================================
  Coverage   90.77%   90.77%           
=======================================
  Files           9        9           
  Lines        1973     1973           
  Branches      144      144           
=======================================
  Hits         1791     1791           
  Misses        142      142           
  Partials       40       40           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lwasser

lwasser commented Jun 18, 2025

Copy link
Copy Markdown
Collaborator

@jsamoocha I'm sitting in a meeting with @miketheman who handles security for the PSF. This PR enhances our Ci workflows by adding specific hashes for each step called in CI using gha-update and zizmor. ✨ !!

@lwasser
lwasser merged commit 7766735 into stravalib:main Jun 18, 2025
PYTHON-VERSION: "3.11"
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pin dependency versions to a specific hash for security

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants