fix(asgi.md): update example with default arg #1161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change ensures the example code works. The code prior to this results in the stack trace below because response is not given a default value.
```
Traceback (most recent call last):
File "/Users/ossareh/local/dev/src/github.com/erisyon/vega_v3/.venv/lib/python3.9/site-packages/uvicorn/protocols/websockets/websockets_impl.py", line 171, in run_asgi
result = await self.app(self.scope, self.asgi_receive, self.asgi_send)
File "/Users/ossareh/local/dev/src/github.com/erisyon/vega_v3/.venv/lib/python3.9/site-packages/uvicorn/middleware/proxy_headers.py", line 59, in __call__
return await self.app(scope, receive, send)
File "/Users/ossareh/local/dev/src/github.com/erisyon/vega_v3/.venv/lib/python3.9/site-packages/strawberry/asgi/__init__.py", line 340, in __call__
await self.handle_websocket(scope=scope, receive=receive, send=send)
File "/Users/ossareh/local/dev/src/github.com/erisyon/vega_v3/.venv/lib/python3.9/site-packages/strawberry/asgi/__init__.py", line 96, in handle_websocket
await self.handle_ws_message(ws, message)
File "/Users/ossareh/local/dev/src/github.com/erisyon/vega_v3/.venv/lib/python3.9/site-packages/strawberry/asgi/__init__.py", line 116, in handle_ws_message
await self.handle_start(ws, message)
File "/Users/ossareh/local/dev/src/github.com/erisyon/vega_v3/.venv/lib/python3.9/site-packages/strawberry/asgi/__init__.py", line 135, in handle_start
context = await self.get_context(ws)
TypeError: get_context() missing 1 required positional argument: 'response'
```
Codecov Report
@@ Coverage Diff @@
## main #1161 +/- ##
=======================================
Coverage 97.65% 97.65%
=======================================
Files 84 84
Lines 3205 3205
Branches 459 459
=======================================
Hits 3130 3130
Misses 41 41
Partials 34 34 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures the example code works. The code prior to this results in the stack trace below because response is not given a default value.