Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial implementation of friendlier errors #2027

Merged
merged 161 commits into from
Dec 4, 2022
Merged

Conversation

patrick91
Copy link
Member

@patrick91 patrick91 commented Jul 18, 2022

I'll add a proper description later, this PR is just for testing the CI steps.

Related: #2107

TODO:

  • assert that documentation exists (via pytest)
  • make all of this optional (flag and checking for imports)
  • Don't fail bad if ast parsing fails (for example with dynamic code)
  • don't add libcst as main dependency
  • print standard exception if we can't find the source (?)
  • redirect from errors.strawberry.rocks
  • add group to allow installing everything (strawberry-graphql[cli] should ok)

Future release:

  • Errors in wasm (if libcst works)

@codecov
Copy link

codecov bot commented Jul 18, 2022

Codecov Report

Merging #2027 (81ab49e) into main (39edd31) will decrease coverage by 0.06%.
The diff coverage is 96.71%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2027      +/-   ##
==========================================
- Coverage   97.87%   97.80%   -0.07%     
==========================================
  Files         163      180      +17     
  Lines        6688     7299     +611     
  Branches     1251     1316      +65     
==========================================
+ Hits         6546     7139     +593     
- Misses         69       76       +7     
- Partials       73       84      +11     

@patrick91 patrick91 force-pushed the feature/better-errors branch 3 times, most recently from e797cfc to 2f24933 Compare July 18, 2022 21:21
@patrick91 patrick91 force-pushed the feature/better-errors branch from 2f24933 to a11715a Compare July 18, 2022 21:33
@patrick91 patrick91 force-pushed the feature/better-errors branch from 74396da to 2d3588e Compare August 14, 2022 20:50
@patrick91
Copy link
Member Author

/pre-release

@patrick91
Copy link
Member Author

/pre-release

@patrick91
Copy link
Member Author

/pre-release

@patrick91 patrick91 force-pushed the feature/better-errors branch 2 times, most recently from 90bbaf9 to b97e0b1 Compare December 4, 2022 16:51
@patrick91 patrick91 force-pushed the feature/better-errors branch from b97e0b1 to edf5cef Compare December 4, 2022 17:18
@patrick91
Copy link
Member Author

/pre-release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants