Skip to content

(deps) upgrade to msgspec>=0.19.0 to fix py313@macos - #3764

Merged
bellini666 merged 1 commit into
strawberry-graphql:mainfrom
alexey-pelykh:fix/macos-py313
Feb 3, 2025
Merged

bellini666 merged 1 commit into
strawberry-graphql:mainfrom
alexey-pelykh:fix/macos-py313

Conversation

@alexey-pelykh

@alexey-pelykh alexey-pelykh commented Feb 2, 2025 •

Copy link
Copy Markdown
Contributor

Description

poetry install --with integrations fails on MacOS with Python 3.13

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation

Issues Fixed or Closed by This PR

N/A

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Summary by Sourcery

Upgrade msgspec to version >=0.19.0 to fix compatibility issues with Python 3.13 on MacOS.

Bug Fixes:

  • Resolve an issue where poetry install --with integrations failed on MacOS with Python 3.13.

Chores:

  • Add a RELEASE.md file.

@sourcery-ai

sourcery-ai Bot commented Feb 2, 2025 •

Copy link
Copy Markdown
Contributor

Reviewer's Guide by Sourcery

This pull request upgrades the msgspec dependency to version 0.19.0 or higher to address a bug that causes installation failures on MacOS with Python 3.13.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Upgraded the msgspec dependency to version 0.19.0 or higher.
  • Updated the msgspec dependency in the poetry.lock file.
poetry.lock
Added a release note to the RELEASE.md file.
  • Added a release note indicating a patch release.
  • Added a release note describing the dependency upgrade.
RELEASE.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @alexey-pelykh - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@bellini666 bellini666 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is only bumping the poetry.lock, it won't affect the release version, so I would say that we don't need a release in here, as it will only affect dev

@alexey-pelykh

Copy link
Copy Markdown
Contributor Author

@bellini666 RELEASE.md removed

@bellini666
bellini666 merged commit 407b14f into strawberry-graphql:main Feb 3, 2025
@botberry

botberry commented Feb 3, 2025

Copy link
Copy Markdown
Member

Thanks for contributing to Strawberry! 🎉 You've been invited to join
the Strawberry GraphQL organisation 😊

You can also request a free sticker by filling this form: https://forms.gle/dmnfQUPoY5gZbVT67

And don't forget to join our discord server: https://strawberry.rocks/discord 🔥

@alexey-pelykh
alexey-pelykh deleted the fix/macos-py313 branch February 3, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants