Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 4 support #7

Merged
merged 2 commits into from
Jan 17, 2013
Merged

Rails 4 support #7

merged 2 commits into from
Jan 17, 2013

Conversation

Envek
Copy link
Contributor

@Envek Envek commented Jan 15, 2013

As of RoR 4 release is coming soon, gems should support it to make migration very easy. :-)

Good news: Rails 4 is supported by this gem out of the box, but gemspec forbids it's installation in rails 4 app. So I've fixed it.

As a bonus I've added testing for all supported rails versions (see Travis build for this pull request).

On a local machine:

rm Gemfile.lock 
rm spec/dummy/db/*.sqlite3 
export RAILS_VERSION=4.0
bundle install --binstubs
bundle exec spec/ci.sh

P.S> Thanks for a gem, that makes axlsx installation super easy!

@straydogstudio
Copy link
Collaborator

Fantastic! I hadn't gotten around to Rails 4, nor the Travis CI changes.
Will look at it in the next few days.

And you're welcome. I had just happened to need a better excel export and
buy 'Crafting Rails Applications' at the same time. It was a perfect fit to
try it out! Axlsx is a great gem.

Noel

On Mon, Jan 14, 2013 at 9:43 PM, Novikov Andrey notifications@github.comwrote:

Rails 4 is supported by this gem out of the box, but gemspec forbids it's
installation in rails 4 app. So I've fixed it.

As a bonus I've added testing for all supported rails versions (see Travis
build for this pull request).

On a local machine:

rm Gemfile.lock
rm spec/dummy/db/*.sqlite3 export RAILS_VERSION=4.0
bundle install --binstubs
bundle exec spec/ci.sh

P.S> Thanks for a gem, that makes axlsx installation super easy!

You can merge this Pull Request by running

git pull https://github.com/Envek/axlsx_rails rails_4_support

Or view, comment on, or merge it at:

#7
Commit Summary

  • Allow to use all rails versions higher than 3.1 in gemspec
  • Allow to use all supported rails versions in one app for testing.

File Changes

  • M .travis.yml (4)
  • M Gemfile (11)
  • M axlsx_rails.gemspec (2)
  • M spec/dummy/config/application.rb (19)
  • M spec/dummy/config/environments/test.rb (2)
  • M spec/dummy/config/routes.rb (14)

Patch Links:

straydogstudio added a commit that referenced this pull request Jan 17, 2013
@straydogstudio straydogstudio merged commit 8e8e133 into caxlsx:master Jan 17, 2013
@Envek Envek deleted the rails_4_support branch January 18, 2013 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants