fix: correctly output filename when watching files #907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-Rath
force-pushed
the
fix-watch-filename
branch
from
d707422
to
a22e3ca
Compare
streamich
pushed a commit
that referenced
this pull request
Jun 2, 2023
## [3.5.2](v3.5.1...v3.5.2) (2023-06-02) ### Bug Fixes * correctly output filename when watching files ([#907](#907)) ([fbde74f](fbde74f))
|
🎉 This PR is included in version 3.5.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses "enough" of the errors described here, and which are currently causing the test suite for
unionfsto fail when using the latest version ofmemfs.I say "enough" because my testing indicates that the current implementation is still not 1:1 with native
fs, and I wouldn't be surprised if this change doesn't work in all cases, but it does make is closer to nativefs🤷