Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

class \core_search\area\base_activity is deprecated #4

Closed
thepurpleblob opened this issue Feb 28, 2019 · 3 comments

Comments

Projects
None yet
4 participants
@thepurpleblob
Copy link

commented Feb 28, 2019

In mod/helixmedia/classes/search/activity.php

The base class should be \core_search\base_activity not \core_search\area\base_activity.

See the upgrade notes in search/upgrade.php under the section for Moodle 3.2.

=== 3.2 ===

* Base search area classes have been renamed, please update your search areas to use the classes below:
  - \core_search\area\base has been renamed to \core_search\base
  - \core_search\area\base_mod has been renamed to \core_search\base_mod
  - \core_search\area\base_activity has been renamed to \core_search\base_activity

In future versions of Moodle, this will fail completely.

thepurpleblob added a commit to thepurpleblob/MEDIAL-Moodle-Activity that referenced this issue Mar 26, 2019

@dustinbrisebois

This comment has been minimized.

Copy link

commented Apr 22, 2019

This has been resolved as of Moodle 3.6 ---

https://github.com/streamingltd/MEDIAL-Moodle-Activity/blob/master/classes/search/activity.php#L36

Is now: class activity extends \core_search\base_activity {

This plugin is not fully Moodle 3.6 compatible.

@aspark21

This comment has been minimized.

Copy link

commented May 28, 2019

This is now a fatal error in 3.7
Fatal error: Class 'core_search\area\base_activity' not found in /path/to/moodle/mod/helixmedia/classes/search/activity.php on line 36

@tim1mw

This comment has been minimized.

Copy link
Contributor

commented Jun 18, 2019

This is fixed in plugin version 2019052102.

@tim1mw tim1mw closed this Jun 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.