From 25e74321261f473807262e2c8bf217a62386f493 Mon Sep 17 00:00:00 2001 From: bastimeyer Date: Thu, 16 May 2024 14:54:22 +0200 Subject: [PATCH] init/instance/nwjs: don't store maximized state See #1009 --- src/app/init/instance-initializers/nwjs/window.js | 4 ++++ src/test/tests/init/instance-initializers/nwjs/window.js | 4 ++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/app/init/instance-initializers/nwjs/window.js b/src/app/init/instance-initializers/nwjs/window.js index 021171e94a..55d85c4771 100644 --- a/src/app/init/instance-initializers/nwjs/window.js +++ b/src/app/init/instance-initializers/nwjs/window.js @@ -79,6 +79,10 @@ function onMove( windowRecord, x, y ) { } function onMaximize( windowRecord, maximized ) { + // HACK: the window `restore` event does not trigger on NW.js >=0.80,<0.84, + // causing the window state to become broken (see #1015): + // Don't store the maximized state for now + maximized = false; return save( windowRecord, { maximized } ); } diff --git a/src/test/tests/init/instance-initializers/nwjs/window.js b/src/test/tests/init/instance-initializers/nwjs/window.js index b60a838440..5d1bfb22a0 100644 --- a/src/test/tests/init/instance-initializers/nwjs/window.js +++ b/src/test/tests/init/instance-initializers/nwjs/window.js @@ -448,7 +448,7 @@ module( "init/instance-initializers/nwjs/window", function( hooks ) { y: 270, width: 960, height: 540, - maximized: true + maximized: false // FIXME: restore this }, "Saves maximized state on maximize" ); @@ -609,7 +609,7 @@ module( "init/instance-initializers/nwjs/window", function( hooks ) { y: 0, width: 1920, height: 1080, - maximized: true + maximized: false // FIXME: restore this }, "Updates the window record only after the event ignore time expires" );