Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Adding i18n/french translation #642
bastimeyer left a comment
Apart from the mistakes mentioned above, the changes are looking good after skimming through them for a bit. Since I don't speak French, I don't know though if there are any other unnoticed translation mistakes left. It's usually better to have a second person proof-read new translations, but if nobody can be found in the next couple of days, we can merge this anyway. I however first want to check and see if there are any layout issues caused by long translation strings, but not today, as it's a bit late for me.
Another thing I'd like to point out are the individual commits of this pull request. Unless this was intended by you, it looks like you've forgot to set your
Oh, and don't worry about the failed CI checks, this is an unrelated issue.
@@ Coverage Diff @@ ## master #642 +/- ## ======================================= Coverage 84.47% 84.47% ======================================= Files 474 474 Lines 13919 13919 Branches 1258 1258 ======================================= Hits 11758 11758 Misses 2065 2065 Partials 96 96