Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding i18n/french translation #642

Open
wants to merge 7 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@selbiselbi
Copy link

commented May 10, 2019

Added a french translation

@bastimeyer
Copy link
Member

left a comment

Hi @selbiselbi,
thanks a lot for taking the time and translating the app! Your work is very much appreciated. 👍

Apart from the mistakes mentioned above, the changes are looking good after skimming through them for a bit. Since I don't speak French, I don't know though if there are any other unnoticed translation mistakes left. It's usually better to have a second person proof-read new translations, but if nobody can be found in the next couple of days, we can merge this anyway. I however first want to check and see if there are any layout issues caused by long translation strings, but not today, as it's a bit late for me.

Another thing I'd like to point out are the individual commits of this pull request. Unless this was intended by you, it looks like you've forgot to set your user.email git config value, which "links" the commits with your github account.
https://help.github.com/en/articles/about-commit-email-addresses
https://help.github.com/en/articles/setting-your-commit-email-address-in-git
If you want to change this, you can rebase the commits and force-push the branch again, or if you don't care, you can leave it as it is and let me (optionally) squash the commits into a single one, which will add you as the author of these commits automatically.

Oh, and don't worry about the failed CI checks, this is an unrelated issue.

Thanks again!

@@ -40,7 +40,7 @@ communities:
community:
menu:
streams: Live Streams
info: Community Infos

This comment has been minimized.

Copy link
@bastimeyer

bastimeyer May 10, 2019

Member

This change needs to be reverted.
The translation string is meant for the sub menu of an individual community. The "Community infos" route lists infos about a community, not about its streams.

community:
menu:
streams: Streams en live
info: Infos sur les streams en live

This comment has been minimized.

Copy link
@bastimeyer

bastimeyer May 10, 2019

Member

This also needs to be changed then.

@bastimeyer bastimeyer added the i18n label May 10, 2019

@codecov

This comment has been minimized.

Copy link

commented May 10, 2019

Codecov Report

Merging #642 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #642   +/-   ##
=======================================
  Coverage   84.47%   84.47%           
=======================================
  Files         474      474           
  Lines       13919    13919           
  Branches     1258     1258           
=======================================
  Hits        11758    11758           
  Misses       2065     2065           
  Partials       96       96
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.