Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more fallback paths for macOS #664

Merged
merged 4 commits into from Oct 6, 2019

Conversation

@kabbala
Copy link
Contributor

commented Oct 4, 2019

add /opt/local/bin path for MacPorts

add /opt/local/bin path for MacPorts
@codecov

This comment has been minimized.

Copy link

commented Oct 4, 2019

Codecov Report

Merging #664 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #664   +/-   ##
=======================================
  Coverage   85.06%   85.06%           
=======================================
  Files         466      466           
  Lines       13991    13991           
  Branches     1261     1261           
=======================================
  Hits        11902    11902           
  Misses       1994     1994           
  Partials       95       95
@bastimeyer

This comment has been minimized.

Copy link
Member

commented Oct 5, 2019

Thanks!
I haven't heard about MacPort yet (not a macOS user), so I don't know how popular and useful it is, but it sounds reasonable to add more fallback paths to the player presets.

/opt/local is the recommended default prefix, right?
https://guide.macports.org/#installing.macports
https://guide.macports.org/#internals.hierarchy

Would you please be so kind and also add the /opt/local/bin fallback path to the VLC player profile? It just makes sense having a MacPorts fallback path for both, especially since VLC is (still) Streamlink's default player.

And just to be sure, both packages have the executable in /opt/local/bin:

@kabbala

This comment has been minimized.

Copy link
Contributor Author

commented Oct 5, 2019

I can't believe you do not use mac, Streamlink gui is very useful and works well in mac!

and yes, Macports is the second popular and second oldest package manager in mac.(and even had involved with Apple) uses /opt/local/bin as path.

VLC provides mac application bundle. but MPV does not.
so i think mac vlc users may not install vlc using package manger. but i will add path for you.

kabbala added 2 commits Oct 6, 2019
add macports and user path for vlc and mpv
someone can install Livestreamer via MacPorts

currently Streamlink is not available in MacPorts
src/config/players.json Outdated Show resolved Hide resolved
src/config/players.json Outdated Show resolved Hide resolved
tilde(~) -> $HOME
@bastimeyer bastimeyer changed the title add /opt/local/bin path for MacPorts Add more fallback paths for macOS Oct 6, 2019
@bastimeyer bastimeyer merged commit 8440029 into streamlink:master Oct 6, 2019
4 checks passed
4 checks passed
codecov/project/app 64.21% (target 50%)
Details
codecov/project/tests 98.8% (target 98%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bastimeyer

This comment has been minimized.

Copy link
Member

commented Oct 6, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.