New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pynsist 2.2 issue - windows installer won't build #2097

Closed
back-to opened this Issue Oct 5, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@back-to
Contributor

back-to commented Oct 5, 2018

Bug Report

  • This is a bug report and I have read the contribution guidelines.

Description

There is a new version of pynsist.

  • new version 2.2 breaks the installer build,
  • old version 2.1 works.

might be a bug of pynsist

https://github.com/takluyver/pynsist
https://pypi.org/project/pynsist/#history

Reproduction steps / Explicit stream URLs to test

  1. ./script/makeinstaller.sh

looks like File /r "streamlinkrc" is the issue

http://nsis.sourceforge.net/Docs/Chapter4.html#file

Log output

~~~ Running makensis ~~~
Processing config: /etc/nsisconf.nsh
Processing script file: "nsis/installer.nsi" (UTF8)
File: "streamlinkrc" -> no files found.
Usage: File [/nonfatal] [/a] ([/r] [/x filespec [...]] filespec [...] |
   /oname=outfile one_file_only)
Error in script "nsis/installer.nsi" on line 174 -- aborting creation process

https://travis-ci.org/streamlink/streamlink/jobs/437722955#L2917-L2921

@bastimeyer

This comment has been minimized.

Show comment
Hide comment
@bastimeyer

bastimeyer Oct 5, 2018

Member

Looks like build/nsis/streamlinkrc gets deleted when pynsist is run in script/makeinstaller.sh. Is there a file-whitelist in pynsist that prevents additional files from existing in the generated pynsist build dir?

Member

bastimeyer commented Oct 5, 2018

Looks like build/nsis/streamlinkrc gets deleted when pynsist is run in script/makeinstaller.sh. Is there a file-whitelist in pynsist that prevents additional files from existing in the generated pynsist build dir?

@bastimeyer

This comment has been minimized.

Show comment
Hide comment
@bastimeyer

bastimeyer Oct 5, 2018

Member

Ok, got confused for a sec... So it seems like pynsist is deleting the entire build/nsis directory before it builds its config files instead of just adding them to the existing dir.

Member

bastimeyer commented Oct 5, 2018

Ok, got confused for a sec... So it seems like pynsist is deleting the entire build/nsis directory before it builds its config files instead of just adding them to the existing dir.

@bastimeyer

This comment has been minimized.

Show comment
Hide comment

bastimeyer added a commit to bastimeyer/streamlink that referenced this issue Oct 5, 2018

pcv12 pushed a commit to pcv12/streamlink that referenced this issue Oct 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment