Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.1.0 release #2349

Open
bastimeyer opened this Issue Mar 9, 2019 · 12 comments

Comments

Projects
None yet
6 participants
@bastimeyer
Copy link
Member

bastimeyer commented Mar 9, 2019

With #2326 being merged, I would appreciate if we could have a new minor release in the next couple of days. This is important for streamlink/streamlink-twitch-gui#618, which relies on a new Streamlink release.

Another thing to consider is the EOL of Python 3.4 next week (2019-03-16). Would it make sense waiting for that to happen first and then removing its support from Streamlink? Or are there any reasons for keeping it?

DEPRECATION: Python 3.4 support has been deprecated. pip 19.1 will be the last one supporting it. Please upgrade your Python as Python 3.4 won't be maintained after March 2019 (cf PEP 429).

https://www.python.org/dev/peps/pep-0429/

@gravyboat

This comment has been minimized.

Copy link
Member

gravyboat commented Mar 9, 2019

New release sounds like a good plan. I'd say we just remove support. for 3.4 even before it is EOL. No reason to keep it. People should keep their Python install up to date.

@bastimeyer bastimeyer referenced this issue Mar 13, 2019

Open

Missing streamlink-script.py on Windows #618

2 of 2 tasks complete
@campones

This comment has been minimized.

Copy link

campones commented Mar 15, 2019

I m still using python 2.7 on my ubuntu server

@skulblakka

This comment has been minimized.

Copy link
Contributor

skulblakka commented Mar 15, 2019

I m still using python 2.7 on my ubuntu server

Well the end of life for Python 2.7 is not reached yet. (It was pushed to 2020).

@bastimeyer

This comment has been minimized.

Copy link
Member Author

bastimeyer commented Mar 15, 2019

@campones

This comment has been minimized.

Copy link

campones commented Mar 16, 2019

good to hear, thanks

@beardypig

This comment has been minimized.

Copy link
Member

beardypig commented Mar 16, 2019

I imagine it will take a while before 2.7 becomes unsupported in streamlink - even if we don’t officially support it after then EOL it, I imagine it will keep on working. Unless we start stripping out the compatibility stuff, which would actually be rather cathartic...

@karlo2105

This comment has been minimized.

Copy link

karlo2105 commented Mar 17, 2019

@beardypig
Please don't strip support for the latest Python 2.7 version released before EOL, nor the latest Python 3 version released for Windows 7, because I don't want to be forced to upgrade to Windows 10 in next 4 or 5 years in order to use the newest streamlink even after Windows 7 EOL. ;-) Keeping compatibility doesn't cost anything.

@gravyboat

This comment has been minimized.

Copy link
Member

gravyboat commented Mar 17, 2019

@karlo2105 While we may allow an old Python 2.7 install to exist (unless some sort of issue comes up regarding security, compatibility annoyances, etc.) we won't support it, and we definitely won't provide support for whatever 3.x releases are EoL past that expiration date. I understand you may not want to upgrade, but that's not something we're going to support. Running EoL software is a security risk and we shouldn't be enabling that behavior.

Keeping compatibility is absolutely costly in terms of work hours, configuration support, testing support, etc. When we have to support old versions via code workarounds or whatever else it makes the code harder to read and annoying for both old and new contributors. If it's worth it to us to remove something so that it's easier for us to maintain we're going to do it for sure.

@gravyboat gravyboat added the release label Mar 17, 2019

@gravyboat

This comment has been minimized.

Copy link
Member

gravyboat commented Mar 17, 2019

@bastimeyer I attempted to do a 1.1.0 release this morning real quick via sh scripts/release.sh (looked at the old instructions) and got some pushd errors even though it's installed accompanied with the changelog not being generated and placed into the updated release file. I'll try to troubleshoot it some more if @cdrage isn't around. I thought the changelog updates were supposed to automatically be generated...

@bastimeyer

This comment has been minimized.

Copy link
Member Author

bastimeyer commented Mar 17, 2019

No need to run that script, it's enough if you copy the format of the previous release in the changelog file and then simply push a new tag (once the release PR was merged).
https://github.com/streamlink/streamlink/blob/1.0.0/script/release.sh#L65-L70
dcd7ed0

@bastimeyer

This comment has been minimized.

Copy link
Member Author

bastimeyer commented Mar 19, 2019

@gravyboat do you want me to open a release PR with a changelog? #2360 needs to be merged before that though

@gravyboat

This comment has been minimized.

Copy link
Member

gravyboat commented Mar 20, 2019

@bastimeyer Yeah sure go for it. Sorry it's been a busy week. #2360 is merged.

@bastimeyer bastimeyer referenced a pull request that will close this issue Mar 20, 2019

Open

Release 1.1.0 #2367

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.