New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: rewrite Windows binaries install section #1408

Merged
merged 1 commit into from Jan 4, 2018

Conversation

Projects
None yet
3 participants
@bastimeyer
Member

bastimeyer commented Jan 3, 2018

  • Cleaned up the whole section
  • Added a table in order to match the other sections. The forced line breaks and short sentences are needed here because of Sphinx' default table styles which I didn't want to modify
  • Changed the link to the the nightly build (resolves #1333)
  • Reworded the PATH env var part
@beardypig

Looks good. I think changing the nightly link is a reasonable compromise.

@gravyboat

This comment has been minimized.

Show comment
Hide comment
@gravyboat

gravyboat Jan 4, 2018

Member

Good changes here @bastimeyer, thanks!

Member

gravyboat commented Jan 4, 2018

Good changes here @bastimeyer, thanks!

@gravyboat gravyboat merged commit aa45712 into streamlink:master Jan 4, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment