New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugins.euronews: fix live stream API URL scheme #2048

Merged
merged 1 commit into from Sep 1, 2018

Conversation

Projects
None yet
2 participants
@bastimeyer
Member

bastimeyer commented Sep 1, 2018

Fixes #2047

This utilizes the update_scheme util method and uses the scheme of the input URL for the missing explicit scheme of the API request URL.

Live streams of various subdomains should be working now, some VODs I've tested (unrelated to these changes) seem to be broken and need to be fixed.

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Sep 1, 2018

Codecov Report

Merging #2048 into master will increase coverage by <.01%.
The diff coverage is 27.27%.

@@            Coverage Diff             @@
##           master    #2048      +/-   ##
==========================================
+ Coverage   51.73%   51.74%   +<.01%     
==========================================
  Files         227      227              
  Lines       13771    13771              
==========================================
+ Hits         7125     7126       +1     
+ Misses       6646     6645       -1

codecov bot commented Sep 1, 2018

Codecov Report

Merging #2048 into master will increase coverage by <.01%.
The diff coverage is 27.27%.

@@            Coverage Diff             @@
##           master    #2048      +/-   ##
==========================================
+ Coverage   51.73%   51.74%   +<.01%     
==========================================
  Files         227      227              
  Lines       13771    13771              
==========================================
+ Hits         7125     7126       +1     
+ Misses       6646     6645       -1
@gravyboat

This comment has been minimized.

Show comment
Hide comment
@gravyboat

gravyboat Sep 1, 2018

Member

Looks good, thanks @bastimeyer.

Member

gravyboat commented Sep 1, 2018

Looks good, thanks @bastimeyer.

@gravyboat gravyboat merged commit a85d364 into streamlink:master Sep 1, 2018

3 checks passed

codecov/project 51.74% (target 30%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment