New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix installer by moving additional files #2098

Merged
merged 1 commit into from Oct 5, 2018

Conversation

Projects
None yet
2 participants
@bastimeyer
Member

bastimeyer commented Oct 5, 2018

Fixes #2097

Pynsist is now cleaning its build dir before it generates the config files, so all additional files which are included in the installer need to be copied to a different directory. I've added the new build/files dir where win32/{streamlinkrc,ffmpeg,rtmpdump} will be copied to. The nsis config file has been changed to load the files from this (absolute) path.

Tested it locally on my machine and the files were correctly included in the built installer.

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Oct 5, 2018

Codecov Report

Merging #2098 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2098   +/-   ##
=======================================
  Coverage   35.91%   35.91%           
=======================================
  Files         230      230           
  Lines       20054    20054           
=======================================
  Hits         7202     7202           
  Misses      12852    12852

codecov bot commented Oct 5, 2018

Codecov Report

Merging #2098 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2098   +/-   ##
=======================================
  Coverage   35.91%   35.91%           
=======================================
  Files         230      230           
  Lines       20054    20054           
=======================================
  Hits         7202     7202           
  Misses      12852    12852
@gravyboat

This comment has been minimized.

Show comment
Hide comment
@gravyboat

gravyboat Oct 5, 2018

Member

Looks good, thanks @bastimeyer.

Member

gravyboat commented Oct 5, 2018

Looks good, thanks @bastimeyer.

@gravyboat gravyboat merged commit e29c8b7 into streamlink:master Oct 5, 2018

3 checks passed

codecov/project 35.91% (target 30%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment