New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for 4K videos in YouTube #225

Merged
merged 11 commits into from Jan 10, 2017

Conversation

Projects
None yet
7 participants
@beardypig
Member

beardypig commented Nov 28, 2016

This PR depends on #224 and should not merged prior to that PR as it includes the commit on that PR.

This PR along with its parent #224, adds support for YouTube videos with resolutions >= 1080p and high frame rate videos, eg. 1080p60. To test this out you will need ffmpeg installed as it uses ffmpeg to mux the separate video and audio streams.

Here are some videos to test out:

A windows installer for this branch is available to download: streamlink-0.1.0-youtube-4k-8b77f99.exe.

@codecov-io

This comment has been minimized.

codecov-io commented Nov 28, 2016

Current coverage is 48.23% (diff: 32.47%)

Merging #225 into master will decrease coverage by 0.39%

@@             master       #225   diff @@
==========================================
  Files            53         54     +1   
  Lines          4618       4735   +117   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           2246       2284    +38   
- Misses         2372       2451    +79   
  Partials          0          0          

Powered by Codecov. Last update 07cc19b...d986b0e

@Junior1544

This comment has been minimized.

Junior1544 commented Nov 28, 2016

Here's a question for you...

Since this uses ffmpeg, how will that effect those of us that use streamlink on a raspberry pi?

I don't know if ffmpeg is compatible with the Raspberry Pi, and will it cause an error on install if ffmpeg doesn't work right, or will just the functions that use ffmpeg not work if ffmpeg doesn't work with Raspberry Pi??

Just some thoughts I had?

@stevek123

This comment has been minimized.

stevek123 commented Nov 28, 2016

I know it's not related, but is it still not working with live streams? For me, when I try to watch a youtube live stream, it says that it's a HLS stream, it opens VLC, and only shows the first frame, and that's all.

@beardypig

This comment has been minimized.

Member

beardypig commented Nov 28, 2016

@Junior1544 for YouTube, if you don't have ffmpeg install it won't show you the streams that require ffmpeg :-)

@stevek123 are you using the VLC 3 beta? I believe that you need to use VLC 3 for YouTube live streams to work.

@Junior1544

This comment has been minimized.

Junior1544 commented Nov 28, 2016

@stevek123

This comment has been minimized.

stevek123 commented Nov 28, 2016

It indeed works with VLC3 nightly

@beardypig

This comment has been minimized.

Member

beardypig commented Nov 29, 2016

I have uploaded a build of the Windows installer for people to test, see the original post for the link.

@gravyboat gravyboat added this to the 0.1.1 milestone Nov 29, 2016

@tp0

This comment has been minimized.

tp0 commented Nov 29, 2016

Just checking that this isn't supposed to have support for live videos?

streamlink https://www.youtube.com/watch?v=Ga3maNZ0x0w
[cli][info] Found matching plugin youtube for URL https://www.youtube.com/watch?v=Ga3maNZ0x0w
Available streams: 144p (worst), 240p, 360p, 480p, 720p, 1080p (best)

Video in question (https://www.youtube.com/watch?v=Ga3maNZ0x0w) is 1080p60.

@beardypig

This comment has been minimized.

Member

beardypig commented Nov 29, 2016

@tp0 I can only see 1080p for that stream, the same that streamlink lists. Are live streams available in higher quality?

@tp0

This comment has been minimized.

tp0 commented Nov 30, 2016

@beardypig Yes, and in Chrome 1080p60 and 720p60 are selectable in the HTML5 player for that video.

@beardypig

This comment has been minimized.

Member

beardypig commented Nov 30, 2016

@tp0 I will see if the 60 fps live versions can be added :-)

@beardypig

This comment has been minimized.

Member

beardypig commented Nov 30, 2016

Looks like live streams use DASH for higher frame rates, when DASH is supported we can add higher frame rate live streams for YouTube.

@Vangelis66

This comment has been minimized.

Vangelis66 commented Dec 1, 2016

If still on WinXP/WinVista, you can try the updated installer here;
see also #224 (comment); contains the fix for #224 (comment), too 👍

EDIT 06/12/2016 00:25 UTC: Updated link to latest version of the installer

@gravyboat gravyboat modified the milestones: 0.1.1, 0.3.0 Dec 23, 2016

beardypig added some commits Nov 30, 2016

win-installer: update the installer so that ffmpeg is installed
Moved both rtmpdump and ffmpeg to separate sections (in a bundled tools subsection), that can be optionally installed during the install. The default is to install both rtmpdump and ffmpeg. If either tool is not installed then the streamlinkrc file is not updated with the path to the tool and must be done manually by the user if they want to use streams that require rtmpdump or ffmpeg.
stream.ffmpegmux: allow options to be passed to the muxer from the st…
…ream and give the option to change the video and audio codecs from copy
@gravyboat

This comment has been minimized.

Member

gravyboat commented Jan 10, 2017

Thanks @beardypig!

@gravyboat gravyboat merged commit db6d5ab into streamlink:master Jan 10, 2017

3 checks passed

codecov/project 48.23% (target 40.00%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@beardypig beardypig deleted the beardypig:youtube-4k branch Jan 20, 2017

fozzysec added a commit to fozzysec/streamlink that referenced this pull request Jan 21, 2017

Support for 4K videos in YouTube (streamlink#225)
* stream.ffmpegmux: add ffmpeg based muxer, used to mux separate video/audio streams

* docs: add reference to ffmpeg in the install docs

* win32: add a Vista compatible ffmpeg 3.2.1 binary

* win-installer: update the installer so that ffmpeg is installed

Moved both rtmpdump and ffmpeg to separate sections (in a bundled tools subsection), that can be optionally installed during the install. The default is to install both rtmpdump and ffmpeg. If either tool is not installed then the streamlinkrc file is not updated with the path to the tool and must be done manually by the user if they want to use streams that require rtmpdump or ffmpeg.

* stream.ffmpegmux: allow options to be passed to the muxer from the stream and give the option to change the video and audio codecs from copy

* stream.ffmpegmux: add command line option to set the video and audio transcode codecs when muxing

* update docs for Streamlink.set_option

* installer: remove ffmpeg and rtmpdump when uninstalling

* cli: add command line options for logging ffmpeg console output

* plugins.youtube: add support for HFR video and >1080p

* plugins.youtube: fix incorrect stream quality name

@gravyboat gravyboat referenced this pull request Feb 7, 2017

Closed

youtube 60fps is not available #548

2 of 4 tasks complete

@gravyboat gravyboat referenced this pull request Apr 8, 2018

Closed

Live 1080p60 Youtube streams don't work in 0.11 #1594

1 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment