Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream.streamprocess: check that a process is usable before using it #2652

Open
wants to merge 1 commit into
base: master
from

Conversation

@beardypig
Copy link
Member

commented Oct 4, 2019

StreamProcess provided an is_usable method, use that method to check if the process can be launch and give a more useful error message if not.

I renamed RTMPStream to rtmpdump, because it uses that. I don't think it will be a problem as it's just a pretty name. @bastimeyer pointed out this was bad :)

src/streamlink/stream/rtmpdump.py Outdated Show resolved Hide resolved
src/streamlink/stream/streamprocess.py Outdated Show resolved Hide resolved
@beardypig beardypig force-pushed the beardypig:rtmpdump-missing-fix branch from 6660645 to e79896e Oct 4, 2019
@codecov

This comment has been minimized.

Copy link

commented Oct 4, 2019

Codecov Report

Merging #2652 into master will decrease coverage by <.01%.
The diff coverage is 37.5%.

@@            Coverage Diff             @@
##           master    #2652      +/-   ##
==========================================
- Coverage   52.75%   52.74%   -0.01%     
==========================================
  Files         243      243              
  Lines       15143    15149       +6     
==========================================
+ Hits         7989     7991       +2     
- Misses       7154     7158       +4
@beardypig beardypig force-pushed the beardypig:rtmpdump-missing-fix branch 2 times, most recently from e79896e to 63c2e14 Oct 4, 2019
StreamProcess provided an is_usable method, use that method to check if
the process can be launch and give a more useful error message if not.
@beardypig beardypig force-pushed the beardypig:rtmpdump-missing-fix branch from 63c2e14 to 178d386 Oct 6, 2019
@back-to back-to added the enhancement label Oct 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.