Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci/travis: install pynsist 2.4 #2655

Merged
merged 1 commit into from Oct 6, 2019

Conversation

@bastimeyer
Copy link
Member

commented Oct 6, 2019

This "bumps" the pynsist (Windows installer) dependency to 2.4 and downloads it from pypi instead of cloning the git repo from github and checking out a pre-release commit ID.

The old commit ID was added because pynsist's author didn't publish a new release when we needed the fixes earlier this year, see here:
https://github.com/takluyver/pynsist/commits/master
This has been resolved now since July.

This PR basically doesn't do much other than making the CI config more readable. Since we're going to add Github actions as a secondary CI service soon, I don't want to have mixed or weird dependency definitions, as it's confusing.

@bastimeyer bastimeyer force-pushed the bastimeyer:ci/travis/pynsist-2.4 branch from 8e3a261 to f504e52 Oct 6, 2019
@codecov

This comment has been minimized.

Copy link

commented Oct 6, 2019

Codecov Report

Merging #2655 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2655   +/-   ##
=======================================
  Coverage   52.75%   52.75%           
=======================================
  Files         243      243           
  Lines       15143    15143           
=======================================
  Hits         7989     7989           
  Misses       7154     7154
@beardypig

This comment has been minimized.

Copy link
Member

commented Oct 6, 2019

Cool. Looks good :)

@gravyboat

This comment has been minimized.

Copy link
Member

commented Oct 6, 2019

Looks good, thanks @bastimeyer.

@gravyboat gravyboat merged commit 0aa18b8 into streamlink:master Oct 6, 2019
3 checks passed
3 checks passed
codecov/project 52.75% (target 30%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.