Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli.output: fix mpv player parameter format #2765

Merged
merged 1 commit into from Jan 12, 2020

Conversation

@bastimeyer
Copy link
Member

bastimeyer commented Jan 12, 2020

Fixes #2764

See mpv-player/mpv@d3cef97

The MPV change is supposed to print out a deprecation warning, but if it causes the player to immediately terminate as described in #2764, this would mean that we should publish a patch release soon. As I've said on Gitter, such a breaking change with the parameter parsing should actually require a major version bump on the side of MPV. Weird.

@bastimeyer bastimeyer force-pushed the bastimeyer:cli/output/mpv-parameters branch from 6df4626 to acd7f07 Jan 12, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 12, 2020

Codecov Report

Merging #2765 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #2765   +/-   ##
=======================================
  Coverage   52.87%   52.87%           
=======================================
  Files         246      246           
  Lines       15428    15428           
=======================================
  Hits         8157     8157           
  Misses       7271     7271
@gravyboat

This comment has been minimized.

Copy link
Member

gravyboat commented Jan 12, 2020

That really is odd they would make this change without a major version bump. Either way, looks good to me. Thanks @bastimeyer.

@gravyboat gravyboat merged commit 40c732c into streamlink:master Jan 12, 2020
3 checks passed
3 checks passed
codecov/project 52.87% (target 30%)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.