Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installer: fix + rewrite streamlinkrc config file #3350

Merged
merged 1 commit into from Nov 20, 2020

Conversation

bastimeyer
Copy link
Member

As mentioned in #3349, the streamlinkrc config file still sets the old --rtmpdump argument which needs to be changed.

This PR also rewrites most of the rather poor descriptions and adds a couple of things.

Further suggestions/improvements are welcome...

Copy link
Member

@gravyboat gravyboat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few suggestions @bastimeyer, no deal breaker issues.

win32/streamlinkrc Outdated Show resolved Hide resolved
win32/streamlinkrc Show resolved Hide resolved
win32/streamlinkrc Outdated Show resolved Hide resolved
@gravyboat
Copy link
Member

Changes look good to me @bastimeyer, if no one else has feedback let's merge this.

@back-to back-to merged commit b86e369 into streamlink:master Nov 20, 2020
@bastimeyer bastimeyer deleted the installer/streamlinkrc branch January 19, 2021 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants