Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream: remove RTMP and RTMPDump dependency #4169

Merged
merged 1 commit into from Nov 13, 2021

Conversation

bastimeyer
Copy link
Member

@bastimeyer bastimeyer commented Nov 13, 2021

  • drop RTMP stream implementation
  • drop RTMP plugin
  • drop RTMPDump dependency
  • remove stream.streamprocess and utils.{rtmp,swf}
  • remove "rtmp" from default stream types list
  • remove "rtmp" from player-passthrough options list
  • remove all --rtmp* CLI args and rtmp-* session options
  • remove all --subprocess-* CLI args and subprocess session options,
    as these were used only by StreamProcess which is no longer needed
  • update tests
  • update docs and CLI argument help texts

ref #4040

This will require all users on Windows (who are using the Windows installer) to update their config files, as --rtmp-rtmpdump and its old deprecated parameter --rtmpdump have been removed, and those were set by default in the config file previously.

I'm not 100% satisfied with the rewritten docs yet in regards to the optional parameters, but this needs to be improved later, not now. I also had to remove one of the example parameters which I wanted to include in the rewritten docs section because of a bug in HTTPStream which I will fix afterwards (method=POST).

- drop RTMP stream implementation
- drop RTMP plugin
- drop RTMPDump dependency
- remove stream.streamprocess and utils.{rtmp,swf}
- remove "rtmp" from default stream types list
- remove "rtmp" from player-passthrough options list
- remove all `--rtmp*` CLI args and `rtmp-*` session options
- remove all `--subprocess-*` CLI args and `subprocess` session options,
  as these were used only by StreamProcess which is no longer needed
- update tests
- update docs and CLI argument help texts
@back-to
Copy link
Collaborator

back-to commented Nov 13, 2021

This will require all users on Windows (who are using the Windows installer) to update their config files, as --rtmp-rtmpdump and its old deprecated parameter --rtmpdump have been removed, and those were set by default in the config file previously.

help=argparse.SUPPRESS might be better instead of completely removing it
or ignore_unknown=True could be used.

@bastimeyer
Copy link
Member Author

Suppressing could be done, but this will be a breaking change anyway, so I don't see a big issue with removing them now. Then there's also the issue with the related CLI args which were not set by the Windows installer config. Still a breaking change, but no intervention required.

I don't mind adding --rtmp-rtmpdump and --rtmpdump back and suppressing them (although it's kinda annoying). You decide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants