Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugins.useetv: log if no link has been found #4547

Closed
wants to merge 2 commits into from

Conversation

BellezaEmporium
Copy link

@BellezaEmporium BellezaEmporium commented May 24, 2022

Why this PR ?

This PR has been made to verify if no link has been found. Indeed, USeeTV doesn't provide all his channels worldwide. Some channels are blocked for Indonesian people only, and some others need a subscription to work (see beIN Asia as an example). Some channels like SeaToday would work, but channels like this one :
image
will only show a Geo-restriction message above the player, telling the end-user he has no access to the stream.

This also reflects inside the player, meaning no link can be scraped.

@mkbloke
Copy link
Member

mkbloke commented May 24, 2022

Thanks. You'll also need to add the following if this is going to be merged:

log = logging.getLogger(__name__)

Add it after the imports with one blank line between and another two blank lines after to pass the linting check.

@BellezaEmporium
Copy link
Author

Thanks. You'll also need to add the following if this is going to be merged:

log = logging.getLogger(__name__)

Add it after the imports with one blank line between and another two blank lines after to pass the linting check.

Sure, going to add it.

per maintainer request.
@mkbloke mkbloke added the plugin enhancement A new feature for a working Plugin label May 24, 2022
Copy link
Member

@bastimeyer bastimeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The elif block is unnecessary, as both if-blocks above already check for the URL being truthy.

Plugins which return/yield no streams already show an error message on the CLI, btw. If you want to show geo-restrictions or account-restrictions, it's better to check the HTTP response with certain XPath queries. Otherwise, it'll show this message even when the user has entered an invalid URL that still gets matched by the plugin.

@mkbloke mkbloke changed the title plugin.useetv : log if no link has been found plugins.useetv: log if no link has been found May 24, 2022
@BellezaEmporium BellezaEmporium deleted the patch-1 branch July 26, 2022 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin enhancement A new feature for a working Plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants