Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components static files / encoding on windows #1936

Closed
danthe3rd opened this issue Aug 28, 2020 · 3 comments · Fixed by #2615
Closed

Components static files / encoding on windows #1936

danthe3rd opened this issue Aug 28, 2020 · 3 comments · Fixed by #2615
Assignees
Labels
area:windows Related to Windows compatibility type:bug Something isn't working

Comments

@danthe3rd
Copy link

danthe3rd commented Aug 28, 2020

Summary

(windows only)
When serving component static files, the encoding is not specified. It falls back to the system's default, which can fail to decode the file.

Steps to reproduce

What are the steps we should take to reproduce the bug:

  1. Set windows system encoding to Japanese
  2. Install hiplot with pip install hiplot
  3. Run the hiplot demo example (https://github.com/facebookresearch/hiplot/blob/master/examples/demo_streamlit.py)

Expected behavior:

Bundle JS file served.

Actual behavior:

Fails with an exception about encoding.
image

Is this a regression?

No

Debug info

This is where the file read happens - encoding should be specified.

Original issue: facebookresearch/hiplot#127

@danthe3rd danthe3rd added type:bug Something isn't working status:needs-triage Has not been triaged by the Streamlit team labels Aug 28, 2020
@tconkling tconkling self-assigned this Aug 28, 2020
@tconkling
Copy link
Contributor

Thanks Dan - I'll take a look shortly

@nthmost nthmost added area:windows Related to Windows compatibility and removed status:needs-triage Has not been triaged by the Streamlit team labels Aug 30, 2020
@danthe3rd
Copy link
Author

Bump. This causes issues for HiPlot users with streamlit on Windows - is it possible to look into it? It should be pretty straightforward to fix (facebookresearch/hiplot#148)
Thank you :)

@kmcgrady
Copy link
Collaborator

kmcgrady commented Mar 9, 2021

@danthe3rd We merged in the PR. That means it can be tested in our next nightly which can be tried out via pip install streamlit-nightly Otherwise, it will be in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:windows Related to Windows compatibility type:bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants