Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark theme does not properly adjust markdown tables #3020

Closed
nickjm opened this issue Mar 25, 2021 · 1 comment · Fixed by #3038
Closed

Dark theme does not properly adjust markdown tables #3020

nickjm opened this issue Mar 25, 2021 · 1 comment · Fixed by #3038
Assignees

Comments

@nickjm
Copy link

nickjm commented Mar 25, 2021

Summary

When I load the latest streamlit in darkmode I cannot see anything in my markdown tables because the text color is changed but not the background color.

Steps to reproduce

Code snippet:

md = """
| Label     | Info        |
| -------- | --------- |
| Row       | Data      |
"""
st.markdown(md)

Expected behavior:

I would expect if the text color get changed to white in the table, the background color should get changed to something dark

Actual behavior:

Both the text color and background are white so nothing can be seen.

Is this a regression?

no, consequence of new theme

Debug info

  • Streamlit version: 0.79.0
  • Python version: 3.7.9
  • pip
  • OS version: MacOS Catalina 10.15.7
  • Browser version: Chrome 89.0.4389.90

Additional information

I'm not sure why markdown tables have different background style but they seem to; perhaps other ui elements would be affected as well.

@nickjm nickjm added type:bug Something isn't working status:needs-triage Has not been triaged by the Streamlit team labels Mar 25, 2021
@vdonato vdonato self-assigned this Mar 25, 2021
@vdonato vdonato removed the status:needs-triage Has not been triaged by the Streamlit team label Mar 25, 2021
@vdonato
Copy link
Collaborator

vdonato commented Mar 25, 2021

Thanks for reporting this @nickjm! I think we probably left in a styling override from before the theming feature was released that sets the background color to white (since at the time it was the one supported background color).

I'll see if I can get a fix out in version 0.80, but at the latest it'll be fixed in 0.81.

vdonato added a commit to vdonato/streamlit that referenced this issue Mar 30, 2021
We ended up letting a markdown table styling bug slip through where tables are
always displayed with a white background color due to an override that I
guess was left over from the pre-theming days.

Closes streamlit#3020
vdonato added a commit that referenced this issue Mar 31, 2021
* Remove incorrect markdown table styling

We ended up letting a markdown table styling bug slip through where tables are
always displayed with a white background color due to an override that I
guess was left over from the pre-theming days.

Closes #3020

* Add snapshots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants