Add unit tests to CLI #1798
Merged
Add unit tests to CLI #1798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added Makefile instruction to create html coverage reports * Updated gitignore to ignore htmlcov folder * Moved CLI test coverage from 76% to 99%
kmcgrady
commented
Aug 1, 2020
| @@ -55,7 +55,7 @@ def _convert_config_option_to_click_option(config_option): | |||
| description = config_option.description | |||
| if config_option.deprecated: | |||
| description += "\n {} - {}".format( | |||
| config_option.deprecation_text, config_option.deprecation_date | |||
| config_option.deprecation_text, config_option.expiration_date | |||
There was a problem hiding this comment.
This is weird. Looks like deprecation_date doesn't exist. I assume based on the structure, it's expiration_date
kantuni
approved these changes
Aug 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #83
Description:
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.