New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tooltips to even more widgets #2594
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
a89b5dd
add help keyword/field to protobufs and api
5bb0af2
add tooltip to TextInput
2efb0a4
remove unnecessary code
9ce2c1c
fix pylint
6c8e2e9
fix pylint stuff
d476240
Merge branch 'tooltips-proto-api-updates' into tooltips-input-text
ff517e1
fix tests
4fb6323
Merge branch 'tooltips-proto-api-updates' into tooltips-input-text
92a561c
Merge branch 'feat/tooltips' into tooltips-input-text
a8bfbf8
remove unnecessary change
c6d4a63
add e2e test
04c2d73
remove unnecessary change
e38b930
save work
0585ba2
get tooltip working with button
549809a
remove unnecessary change
c76a3b7
see if this fixes some cypress tests
babfdb5
make requested changes
e2835cf
Merge branch 'tooltips-input-text' into tooltips-more-widgets-2
22db79b
Merge branch 'feat/tooltips' into tooltips-more-widgets-2
2becbc9
fix merge
131292b
fix imports
db15b2f
update st_tooltips.spec.js
758f650
destructure
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, this applies both to this PR and the other similar ones, but should we consider adding a helper function (or a small wrapper component) that generalizes this code more?
The code below seems replicated a good amount and could be made a single line in most places with a bit of refactoring (although it seems like there are a few places where things slightly differ).