Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of svg image urls #3809

Merged
merged 2 commits into from
Sep 17, 2021
Merged

Conversation

raethlein
Copy link
Collaborator

Issue: #3537

Description: Add a check whether an SVG image string is a URL to avoid trying to read it from the local filesystem. The check could be made more sophisticated or more protocols besides http and https could be added, though I thought that this is very likely the most common scenario.


Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@raethlein raethlein merged commit 12c45ef into streamlit:develop Sep 17, 2021
@raethlein raethlein deleted the bugfix/3537 branch September 17, 2021 09:50
tconkling added a commit to tconkling/streamlit that referenced this pull request Sep 20, 2021
* develop:
  Force wait for rerun to complete before making assertion (streamlit#3816)
  Fix handling of svg image urls (streamlit#3809)
  UI Tweaks - the merge! (streamlit#3792)
  Simplified widget behavior (streamlit#3754)
  Fix for st.metric spacing without delta - streamlit#3720 (streamlit#3799)
  Updates download_button and button docstrings (streamlit#3801)
  Rename Streamlit Sharing with Streamlit Cloud and update links (streamlit#3796)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants