Ensure that session_state.filtered_state can handle missing metadata #3970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that using self.items() in the filtered_state method sometimes breaks in the case that both 1. widget metadata is cleared (because the streamlit server was restarted or the cache+session_state was cleared) 2. we receive the current state of a widget with no metadata from the frontend. In this scenario, the code that we have in the for loop to guard against this case doesn't help us because the KeyError is thrown in the call to self.items() Closes streamlit#3843
vdonato
force-pushed
the
3843/filtered-state-fix
branch
from
91b380a
to
2f9eb55
Compare
kajarenc
approved these changes
Oct 26, 2021
tconkling
added a commit
that referenced
this pull request
Nov 1, 2021
* develop: * Add ability to access secrets by attribute notation. (#3915) Update README (#3948) Ensure that session_state.filtered_state can handle missing metadata (#3970) Stop dev menu being accessed as a viewer (#3968) Implement fail loudly for Bokeh when Bokeh version does not match (2.4.1) (#3966) Bump jquery-ui from 1.12.1 to 1.13.0 in /frontend (#3971) Try using slightly newer Python 3.7 image (#3967)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that using self.items() in the filtered_state method
sometimes breaks in the case that both
restarted or the cache+session_state was cleared)
the frontend.
In this scenario, the code that we have in the for loop to guard against
this case doesn't help us because the KeyError is thrown in the call to
self.items()
Closes #3843