Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix footer alignment in wide mode #4035

Merged
merged 3 commits into from
Nov 12, 2021
Merged

Conversation

LukasMasuch
Copy link
Collaborator

馃摎 Context

Please describe the project or issue background here

When in wide mode, the "Made with Streamlit" footer isn't aligned with the page content.

  • What kind of change does this PR introduce?

    • Bugfix
    • Feature
    • Refactoring
    • Other, please describe:

馃 Description of Changes

  • Apply styling properties for wide mode to footer as well.

    • This is a breaking API change
    • This is a visible (user-facing) change

Revised:

image

Current:

image

馃И Testing Done

  • Screenshots included
  • Added/Updated unit tests
  • Added/Updated e2e tests

馃寪 References

Does this depend on other work, documents, or tickets?


Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

Copy link
Collaborator

@mayagbarnes mayagbarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 馃槃
It may be helpful to add tests for the StyledReportViewFooter when in wide mode and not - perhaps checking for the isWideMode prop the same way ReportView.test.tsx does for the StyledReportViewBlockContainer, or alternatively using a jest snapshot.

@LukasMasuch
Copy link
Collaborator Author

@mayagbarnes Thanks for the review :) I added the StyledReportViewFooter to the wide mode tests of the ReportView.

@mayagbarnes
Copy link
Collaborator

mayagbarnes commented Nov 11, 2021

@LukasMasuch Of course! Looks great 馃殌

@LukasMasuch LukasMasuch merged commit e98f385 into streamlit:develop Nov 12, 2021
@LukasMasuch LukasMasuch deleted the fix/3923 branch November 12, 2021 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Left-align "Made with Streamlit" when in wide mode
3 participants